Changeset 244271 in webkit

Timestamp:

Apr 15, 2019, 10:31:46 AM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: null is not an object (evaluating 'this.selectedTreeElement.reveal')
​https://bugs.webkit.org/show_bug.cgi?id=196804
<rdar://problem/49800708>

Reviewed by Timothy Hatcher.

• UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype.update):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeOutline.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-15  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: null is not an object (evaluating 'this.selectedTreeElement.reveal')
+        https://bugs.webkit.org/show_bug.cgi?id=196804
+        <rdar://problem/49800708>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/DOMTreeOutline.js:
+        (WI.DOMTreeOutline.prototype.update):
+
 2019-04-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js

@@ -198 +198 @@
         });
 
+        // It's possible that a previously selected node will no longer exist (e.g. after navigation).
+        selectedTreeElements = selectedTreeElements.filter((x) => !!x);
+
+        if (!selectedTreeElements.length)
+            return;
+
         this.selectTreeElements(selectedTreeElements);
-        this.selectedTreeElement.reveal();
+
+        if (this.selectedTreeElement)
+            this.selectedTreeElement.reveal();
     }