Changeset 244328 in webkit

Timestamp:

Apr 16, 2019, 1:03:56 AM (7 years ago)

Author:

graouts@webkit.org

Message:

[iOS] Redundant pointer events causes material design buttons to flush twice
​https://bugs.webkit.org/show_bug.cgi?id=196914
<rdar://problem/49571860>

Reviewed by Dean Jackson.

Source/WebCore:

Test: pointerevents/ios/pointer-event-order.html

Do not dispatch pointer events for mouse events on iOS since we're already dispatching them when processing touch events.

• dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

LayoutTests:

Add a new test that listens to all pointer event types as well as click, which forces the dispatch of compatibility mouse events
along with the click which would trigger duplicated pointer events prior to the source changes.

To ensure the new test added runs smoothly with a preceeding test that also uses ui.tap(), we add a delay to guarantee that no
double-taps are seen rather two successive single taps.

• pointerevents/ios/pointer-event-order-expected.txt: Added.
• pointerevents/ios/pointer-event-order.html: Added.
• pointerevents/utils.js:

(const.ui.new.UIController.prototype.tap):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/pointerevents/ios/pointer-event-order-expected.txt (added)
• LayoutTests/pointerevents/ios/pointer-event-order.html (added)
• LayoutTests/pointerevents/utils.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-15  Antoine Quint  <graouts@apple.com>
+
+        [iOS] Redundant pointer events causes material design buttons to flush twice
+        https://bugs.webkit.org/show_bug.cgi?id=196914
+        <rdar://problem/49571860>
+
+        Reviewed by Dean Jackson.
+
+        Add a new test that listens to all pointer event types as well as click, which forces the dispatch of compatibility mouse events
+        along with the click which would trigger duplicated pointer events prior to the source changes.
+
+        To ensure the new test added runs smoothly with a preceeding test that also uses ui.tap(), we add a delay to guarantee that no
+        double-taps are seen rather two successive single taps.
+
+        * pointerevents/ios/pointer-event-order-expected.txt: Added.
+        * pointerevents/ios/pointer-event-order.html: Added.
+        * pointerevents/utils.js:
+        (const.ui.new.UIController.prototype.tap):
+
 2019-04-15  John Wilander  <wilander@apple.com>
 

trunk/LayoutTests/pointerevents/utils.js

@@ -121 +121 @@
     tap(options)
     {
-        return this._run(`uiController.singleTapAtPoint(${options.x}, ${options.y})`);
+        // Add a delay to ensure sequence of tap() calls don't yield double taps.
+        const delay = 1000;
+        return this._run(`uiController.singleTapAtPoint(${options.x}, ${options.y})`).then(() => {
+            return new Promise(resolve => setTimeout(resolve, delay));
+        });
     }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-15  Antoine Quint  <graouts@apple.com>
+
+        [iOS] Redundant pointer events causes material design buttons to flush twice
+        https://bugs.webkit.org/show_bug.cgi?id=196914
+        <rdar://problem/49571860>
+
+        Reviewed by Dean Jackson.
+
+        Test: pointerevents/ios/pointer-event-order.html
+
+        Do not dispatch pointer events for mouse events on iOS since we're already dispatching them when processing touch events.
+
+        * dom/Element.cpp:
+        (WebCore::Element::dispatchMouseEvent):
+
 2019-04-15  John Wilander  <wilander@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -303 +303 @@
     bool didNotSwallowEvent = true;
 
-#if ENABLE(POINTER_EVENTS)
+#if ENABLE(POINTER_EVENTS) && !ENABLE(TOUCH_EVENTS)
     if (RuntimeEnabledFeatures::sharedFeatures().pointerEventsEnabled()) {
         if (auto pointerEvent = PointerEvent::create(mouseEvent)) {