Changeset 244359 in webkit

Timestamp:

Apr 16, 2019, 2:35:13 PM (7 years ago)

Author:

wilander@apple.com

Message:

Set test conditions closer to conversion redirect in LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html
​https://bugs.webkit.org/show_bug.cgi?id=196983
<rdar://problem/49952679>

Unreviewed test gardening.

• http/tests/adClickAttribution/resources/redirectToConversion.php:
• http/tests/adClickAttribution/send-attribution-conversion-request.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/adClickAttribution/resources/redirectToConversion.php (modified) (1 diff)
• http/tests/adClickAttribution/send-attribution-conversion-request.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-16  John Wilander  <wilander@apple.com>
+
+        Set test conditions closer to conversion redirect in LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html
+        https://bugs.webkit.org/show_bug.cgi?id=196983
+        <rdar://problem/49952679>
+
+        Unreviewed test gardening.
+
+        * http/tests/adClickAttribution/resources/redirectToConversion.php:
+        * http/tests/adClickAttribution/send-attribution-conversion-request.html:
+
 2019-04-16  Devin Rousso  <drousso@apple.com>
 

trunk/LayoutTests/http/tests/adClickAttribution/resources/redirectToConversion.php

@@ -1 +1 @@
 <?php
 header("HTTP/1.0 302 Found");
+header("Cache-Control: no-cache, no-store, must-revalidate");
 if (isset($_GET["conversionData"]) && isset($_GET["priority"])) {
   header("Location: /.well-known/ad-click-attribution/" . $_GET["conversionData"] . "/" . $_GET["priority"]);

trunk/LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html

@@ -19 +19 @@
         testRunner.dumpChildFramesAsText();
         testRunner.setAllowsAnySSLCertificate(true);
-        testRunner.setAdClickAttributionOverrideTimerForTesting(true);
     }
 
@@ -42 +41 @@
 
         let iframeElement = document.createElement("iframe");
-        iframeElement.src = "http://127.0.0.1:8000/adClickAttribution/resources/getConversionData.php?endTest=true&timeout_ms=4000&nonce=" + nonce;
+        iframeElement.src = "http://127.0.0.1:8000/adClickAttribution/resources/getConversionData.php?endTest=true&timeout_ms=2000&nonce=" + nonce;
         document.body.appendChild(iframeElement);
     }
@@ -49 +48 @@
         if (window.testRunner) {
             if (window.location.search === "?stepTwo") {
-                testRunner.setAdClickAttributionConversionURLForTesting("http://127.0.0.1:8000/adClickAttribution/resources/conversionReport.php?nonce=" + nonce);
                 let imageElement = document.createElement("img");
-                imageElement.src = "https://127.0.0.1:8443/adClickAttribution/resources/redirectToConversion.php?conversionData=12";
+                imageElement.src = "https://127.0.0.1:8443/adClickAttribution/resources/redirectToConversion.php?conversionData=12&nonce=" + nonce;
                 imageElement.id = "pixel";
                 imageElement.onerror = function() {
                     appendConversionDataIframeAndFinish();
                 };
+                testRunner.setAdClickAttributionConversionURLForTesting("http://127.0.0.1:8000/adClickAttribution/resources/conversionReport.php?nonce=" + nonce);
+                testRunner.setAdClickAttributionOverrideTimerForTesting(true);
                 document.body.appendChild(imageElement);
             } else {