Changeset 244663 in webkit

Timestamp:

Apr 25, 2019, 2:27:10 PM (7 years ago)

Author:

achristensen@apple.com

Message:

Fix more Windows builds after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

• svg/properties/SVGAnimatedPropertyList.h:
• svg/properties/SVGProperty.h:
• svg/properties/SVGPropertyList.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/properties/SVGAnimatedPropertyList.h (modified) (1 diff)
• svg/properties/SVGProperty.h (modified) (1 diff)
• svg/properties/SVGPropertyList.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-25  Alex Christensen  <achristensen@webkit.org>
+
+        Fix more Windows builds after r244653
+        https://bugs.webkit.org/show_bug.cgi?id=197131
+
+        * svg/properties/SVGAnimatedPropertyList.h:
+        * svg/properties/SVGProperty.h:
+        * svg/properties/SVGPropertyList.h:
+
 2019-04-25  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/svg/properties/SVGAnimatedPropertyList.h

@@ -110 +110 @@
     }
 
+    // Visual Studio doesn't seem to see these private constructors from subclasses.
+    // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
 protected:
+#endif
     template<typename... Arguments>
     SVGAnimatedPropertyList(SVGElement* contextElement, Arguments&&... arguments)

trunk/Source/WebCore/svg/properties/SVGProperty.h

@@ -84 +84 @@
     virtual String valueAsString() const { return emptyString(); }
 
+    // Visual Studio doesn't seem to see these private constructors from subclasses.
+    // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
 protected:
+#endif
     SVGProperty(SVGPropertyOwner* owner = nullptr, SVGPropertyAccess access = SVGPropertyAccess::ReadWrite)
         : m_owner(owner)

trunk/Source/WebCore/svg/properties/SVGPropertyList.h

@@ -38 +38 @@
     using BaseList::append;
 
+    // Visual Studio doesn't seem to see these private constructors from subclasses.
+    // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
 protected:
+#endif
     using SVGPropertyOwner::SVGPropertyOwner;
     using BaseList::m_items;