Changeset 244752 in webkit

Timestamp:

Apr 29, 2019, 1:45:26 PM (7 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r238090): animation on ​https://www.robotodyssey.online gets stuck; site broken
​https://bugs.webkit.org/show_bug.cgi?id=197381
Source/WebCore:

Reviewed by Zalan Bujtas.

When -webkit-clip-path changes on a composited layer, we need to trigger a backing geometry update
to push the changes to GraphicsLayers.

Test: compositing/style-change/clip-path-change.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::recompositeChangeRequiresGeometryUpdate):

LayoutTests:

<rdar://problem/50308128>

Reviewed by Zalan Bujtas.

• compositing/style-change/clip-path-change-expected.html: Added.
• compositing/style-change/clip-path-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (2 diffs)
• LayoutTests/compositing/style-change/clip-path-change-expected.html (added)
• LayoutTests/compositing/style-change/clip-path-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-04-29  Javier Fernandez  <jfernandez@igalia.com>
+
+        line should not be broken before the first space after a word
+        https://bugs.webkit.org/show_bug.cgi?id=197278
+
+        Reviewed by Myles C. Maxfield.
+
+        Added a few Skip (due to unimplemented features) and Failure (break-all related
+        issues) entries for some of the tests added by this patch.
+
+        * TestExpectations:
+
 2019-04-29  Youenn Fablet  <youenn@apple.com>
 
@@ -16 +28 @@
         * resources/testharnessreport.js:
 
-2019-04-29  Javier Fernandez  <jfernandez@igalia.com>
-
-        line should not be broken before the first space after a word
-        https://bugs.webkit.org/show_bug.cgi?id=197278
-
-        Reviewed by Myles C. Maxfield.
-
-        Added a few Skip (due to unimplemented features) and Failure (break-all related
-        issues) entries for some of the tests added by this patch.
-
-        * TestExpectations:
+2019-04-29  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site broken
+        https://bugs.webkit.org/show_bug.cgi?id=197381
+        <rdar://problem/50308128>
+
+        Reviewed by Zalan Bujtas.
+
+        * compositing/style-change/clip-path-change-expected.html: Added.
+        * compositing/style-change/clip-path-change.html: Added.
 
 2019-04-29  Youenn Fablet  <youenn@apple.com>

trunk/Source/WebCore/ChangeLog

@@ -73 +73 @@
         (WebCore::BreakingContext::handleText):
         (WebCore::BreakingContext::trailingSpacesHang):
+
+2019-04-29  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r238090): animation on https://www.robotodyssey.online gets stuck; site broken
+        https://bugs.webkit.org/show_bug.cgi?id=197381
+
+        Reviewed by Zalan Bujtas.
+
+        When -webkit-clip-path changes on a composited layer, we need to trigger a backing geometry update
+        to push the changes to GraphicsLayers.
+
+        Test: compositing/style-change/clip-path-change.html
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::recompositeChangeRequiresGeometryUpdate):
 
 2019-04-29  Chris Dumez  <cdumez@apple.com>

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -1435 +1435 @@
         || oldStyle.perspectiveOriginX() != newStyle.perspectiveOriginX()
         || oldStyle.perspectiveOriginY() != newStyle.perspectiveOriginY()
-        || oldStyle.backfaceVisibility() != newStyle.backfaceVisibility();
+        || oldStyle.backfaceVisibility() != newStyle.backfaceVisibility()
+        || !arePointingToEqualData(oldStyle.clipPath(), newStyle.clipPath());
 }