Changeset 244768 in webkit

Timestamp:

Apr 30, 2019, 7:32:43 AM (7 years ago)

Author:

Michael Catanzaro

Message:

WebCore::StyleColorScheme should not have explicitly-declared copy constructor
​https://bugs.webkit.org/show_bug.cgi?id=197412

Reviewed by Don Olmstead.

Either we need to explicitly declare a copy assignment operator here, or the copy
constructor needs to be removed. Having one without the other causes a huge warning spam
with GCC 9. In this case, the copy constructor is redundant because it's identical to an
implicitly-declared copy constructor, so let's just remove it.

• rendering/style/StyleColorScheme.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/StyleColorScheme.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        WebCore::StyleColorScheme should not have explicitly-declared copy constructor
+        https://bugs.webkit.org/show_bug.cgi?id=197412
+
+        Reviewed by Don Olmstead.
+
+        Either we need to explicitly declare a copy assignment operator here, or the copy
+        constructor needs to be removed. Having one without the other causes a huge warning spam
+        with GCC 9. In this case, the copy constructor is redundant because it's identical to an
+        implicitly-declared copy constructor, so let's just remove it.
+
+        * rendering/style/StyleColorScheme.h:
+
 2019-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/rendering/style/StyleColorScheme.h

@@ -37 +37 @@
     StyleColorScheme() { }
 
-    StyleColorScheme(const StyleColorScheme& other)
-        : m_colorScheme(other.m_colorScheme)
-        , m_allowsTransformations(other.m_allowsTransformations)
-    { }
-
     StyleColorScheme(OptionSet<ColorScheme> colorScheme, bool allowsTransformations)
         : m_colorScheme(colorScheme)