Changeset 244771 in webkit

Timestamp:

Apr 30, 2019, 8:03:38 AM (7 years ago)

Author:

youenn@apple.com

Message:

Refactor AudioContext to register/unregister itself at construction/destruction time
​https://bugs.webkit.org/show_bug.cgi?id=197383

Reviewed by Eric Carlson.

Registering/Unregistering is cheap.
Instead of registering/unregistering in initialize/uninitialize,
move this code to constructor/destructor.
No observable change of behavior.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::visibilityStateChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/AudioContext.cpp (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-30  Youenn Fablet  <youenn@apple.com>
+
+        Refactor AudioContext to register/unregister itself at construction/destruction time
+        https://bugs.webkit.org/show_bug.cgi?id=197383
+
+        Reviewed by Eric Carlson.
+
+        Registering/Unregistering is cheap.
+        Instead of registering/unregistering in initialize/uninitialize,
+        move this code to constructor/destructor.
+        No observable change of behavior.
+
+        * Modules/webaudio/AudioContext.cpp:
+        (WebCore::AudioContext::AudioContext):
+        (WebCore::AudioContext::~AudioContext):
+        (WebCore::AudioContext::lazyInitialize):
+        (WebCore::AudioContext::uninitialize):
+        (WebCore::AudioContext::visibilityStateChanged):
+
 2019-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp

@@ -148 +148 @@
     // Initialize the destination node's muted state to match the page's current muted state.
     pageMutedStateDidChange();
+
+    if (!isOfflineContext()) {
+        document.addAudioProducer(*this);
+        document.registerForVisibilityStateChangedCallbacks(*this);
+    }
 }
 
@@ -203 +208 @@
     ASSERT(m_renderingAutomaticPullNodes.isEmpty());
     // FIXME: Can we assert that m_deferredFinishDerefList is empty?
+
+    if (!isOfflineContext() && scriptExecutionContext()) {
+        document()->removeAudioProducer(*this);
+        document()->unregisterForVisibilityStateChangedCallbacks(*this);
+    }
 }
 
@@ -219 +229 @@
 
         if (!isOfflineContext()) {
-            document()->addAudioProducer(*this);
-            document()->registerForVisibilityStateChangedCallbacks(*this);
-
             // This starts the audio thread. The destination node's provideInput() method will now be called repeatedly to render audio.
             // Each time provideInput() is called, a portion of the audio stream is rendered. Let's call this time period a "render quantum".
@@ -266 +273 @@
 
     if (!isOfflineContext()) {
-        document()->removeAudioProducer(*this);
-        document()->unregisterForVisibilityStateChangedCallbacks(*this);
-
         ASSERT(s_hardwareContextCount);
         --s_hardwareContextCount;
@@ -379 +383 @@
 {
     // Do not suspend if audio is audible.
-    if (mediaState() == MediaProducer::IsPlayingAudio)
+    if (mediaState() == MediaProducer::IsPlayingAudio || m_isStopScheduled)
         return;