Changeset 244796 in webkit

Timestamp:

Apr 30, 2019, 1:08:01 PM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r244632. rdar://problem/50344188

Do not restart WebRTC stats timer if backend is stopped
​https://bugs.webkit.org/show_bug.cgi?id=197257
<rdar://problem/50095879>

Reviewed by Eric Carlson.

We used to stop and reschedule the stat gathering timer in case the
gathering delay is changing. Timer should not be rescheduled if the backend is stopped.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607.2.6.1-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (modified) (1 diff)

branches/safari-607.2.6.1-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-30  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r244632. rdar://problem/50344188
+
+    Do not restart WebRTC stats timer if backend is stopped
+    https://bugs.webkit.org/show_bug.cgi?id=197257
+    <rdar://problem/50095879>
+    
+    Reviewed by Eric Carlson.
+    
+    We used to stop and reschedule the stat gathering timer in case the
+    gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+    
+    * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+    (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-04-24  Youenn Fablet  <youenn@apple.com>
+
+            Do not restart WebRTC stats timer if backend is stopped
+            https://bugs.webkit.org/show_bug.cgi?id=197257
+            <rdar://problem/50095879>
+
+            Reviewed by Eric Carlson.
+
+            We used to stop and reschedule the stat gathering timer in case the
+            gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+
+            * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+            (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+
 2019-04-10  Alan Coon  <alancoon@apple.com>
 

branches/safari-607.2.6.1-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

@@ -848 +848 @@
 
     callOnMainThread([protectedThis = makeRef(*this), this, timestamp, report] {
-        if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
+        if (m_backend && m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
             m_statsLogTimer.stop();
             m_statsLogTimer.startRepeating(statsLogInterval(timestamp));