Changeset 244829 in webkit

Timestamp:

May 1, 2019, 10:36:40 AM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r242772. rdar://problem/50352729

Web Inspector: REGRESSION: Network Cookies Table does not load
​https://bugs.webkit.org/show_bug.cgi?id=195599

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-11
Reviewed by Devin Rousso.

• UserInterface/Views/ResourceCookiesContentView.js: (WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject): (WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex): Include needed delegate methods.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607-branch/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ResourceCookiesContentView.js (modified) (1 diff)

branches/safari-607-branch/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-04-30  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r242772. rdar://problem/50352729
+
+    Web Inspector: REGRESSION: Network Cookies Table does not load
+    https://bugs.webkit.org/show_bug.cgi?id=195599
+    
+    Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-03-11
+    Reviewed by Devin Rousso.
+    
+    * UserInterface/Views/ResourceCookiesContentView.js:
+    (WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
+    (WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
+    Include needed delegate methods.
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-03-11  Joseph Pecoraro  <pecoraro@apple.com>
+
+            Web Inspector: REGRESSION: Network Cookies Table does not load
+            https://bugs.webkit.org/show_bug.cgi?id=195599
+
+            Reviewed by Devin Rousso.
+
+            * UserInterface/Views/ResourceCookiesContentView.js:
+            (WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
+            (WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
+            Include needed delegate methods.
+
 2019-04-24  Alan Coon  <alancoon@apple.com>
 

branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js

@@ -57 +57 @@
     }
 
+    tableIndexForRepresentedObject(table, object)
+    {
+        let cookies = this._dataSourceForTable(table);
+        let index = cookies.indexOf(object);
+        console.assert(index >= 0);
+        return index;
+    }
+
+    tableRepresentedObjectForIndex(table, index)
+    {
+        let cookies = this._dataSourceForTable(table);
+        console.assert(index >= 0 && index < cookies.length);
+        return cookies[index];
+    }
+
     // Table delegate