Changeset 244830 in webkit

Timestamp:

May 1, 2019, 10:36:43 AM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r244326. rdar://problem/50352719

Web Inspector: CRASH when reopening tab with docked inspector on crashed page
​https://bugs.webkit.org/show_bug.cgi?id=196954
<rdar://problem/48716433>

Reviewed by Ryosuke Niwa.

• UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@244326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-607-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WebInspectorProxyMac.mm (modified) (1 diff)

branches/safari-607-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-30  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r244326. rdar://problem/50352719
+
+    Web Inspector: CRASH when reopening tab with docked inspector on crashed page
+    https://bugs.webkit.org/show_bug.cgi?id=196954
+    <rdar://problem/48716433>
+    
+    Reviewed by Ryosuke Niwa.
+    
+    * UIProcess/mac/WebInspectorProxyMac.mm:
+    (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-04-15  Joseph Pecoraro  <pecoraro@apple.com>
+
+            Web Inspector: CRASH when reopening tab with docked inspector on crashed page
+            https://bugs.webkit.org/show_bug.cgi?id=196954
+            <rdar://problem/48716433>
+
+            Reviewed by Ryosuke Niwa.
+
+            * UIProcess/mac/WebInspectorProxyMac.mm:
+            (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
+
 2019-04-24  Alan Coon  <alancoon@apple.com>
 

branches/safari-607-branch/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm

@@ -556 +556 @@
     }
 
+    if (!inspectedPage())
+        return;
+
     NSView *inspectedView = inspectedPage()->inspectorAttachmentView();
     WKWebView *inspectorView = [m_inspectorViewController webView];