Changeset 244836 in webkit

Timestamp:

May 1, 2019, 12:17:05 PM (7 years ago)

Author:

dino@apple.com

Message:

Link Previews that use WKImagePreviewViewController are not always scaled correctly
​https://bugs.webkit.org/show_bug.cgi?id=197450
<rdar://problem/50357695>

Reviewed by Wenson Hsieh.

Tell the UIImageView that we create in WKImagePreviewViewController to use
a filling scaling method.

• UIProcess/WKImagePreviewViewController.mm:

(-[WKImagePreviewViewController initWithCGImage:defaultActions:elementInfo:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WKImagePreviewViewController.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-01  Dean Jackson  <dino@apple.com>
+
+        Link Previews that use WKImagePreviewViewController are not always scaled correctly
+        https://bugs.webkit.org/show_bug.cgi?id=197450
+        <rdar://problem/50357695>
+
+        Reviewed by Wenson Hsieh.
+
+        Tell the UIImageView that we create in WKImagePreviewViewController to use
+        a filling scaling method.
+
+        * UIProcess/WKImagePreviewViewController.mm:
+        (-[WKImagePreviewViewController initWithCGImage:defaultActions:elementInfo:]):
+
 2019-05-01  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit/UIProcess/WKImagePreviewViewController.mm

@@ -54 +54 @@
 
     _imageView = adoptNS([[UIImageView alloc] initWithFrame:CGRectZero]);
+    _imageView.get().contentMode = UIViewContentModeScaleAspectFill;
     RetainPtr<UIImage> uiImage = adoptNS([[UIImage alloc] initWithCGImage:_image.get()]);
     [_imageView setImage:uiImage.get()];