Changeset 24494 in webkit


Ignore:
Timestamp:
Jul 20, 2007 3:59:23 PM (17 years ago)
Author:
adachan
Message:

2007-07-20 Ada Chan <adachan@apple.com>

Reviewed by Steve.


<rdar://problem/5350832> History item's visitedCount wasn't updated correctly

The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
really increment the visitedCount of the HistoryItem - because we only increment the count
if the last visited time is different. We should initialize the HistoryItem with
lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
the last visited time AND the visitedCount.


  • WebHistory.cpp: (WebHistory::addItemForURL):
Location:
trunk/WebKit/win
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/win/ChangeLog

    r24469 r24494  
     12007-07-20  Ada Chan  <adachan@apple.com>
     2
     3        Reviewed by Steve.
     4       
     5        <rdar://problem/5350832> History item's visitedCount wasn't updated correctly
     6
     7        The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
     8        really increment the visitedCount of the HistoryItem - because we only increment the count
     9        if the last visited time is different.  We should initialize the HistoryItem with
     10        lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
     11        the last visited time AND the visitedCount.
     12       
     13        * WebHistory.cpp:
     14        (WebHistory::addItemForURL):
     15
    1162007-07-20  Oliver Hunt  <oliver@apple.com>
    217
  • trunk/WebKit/win/WebHistory.cpp

    r23828 r24494  
    663663        return E_FAIL;
    664664
    665     HRESULT hr = item->initWithURLString(url, title, lastVisited);
     665    HRESULT hr = item->initWithURLString(url, title, 0);
    666666    if (FAILED(hr))
    667667        return hr;
Note: See TracChangeset for help on using the changeset viewer.