Changeset 24494 in webkit

Timestamp:

Jul 20, 2007, 3:59:23 PM (18 years ago)

Author:

adachan

Message:

2007-07-20 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

<rdar://problem/5350832> History item's visitedCount wasn't updated correctly

The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
really increment the visitedCount of the HistoryItem - because we only increment the count
if the last visited time is different. We should initialize the HistoryItem with
lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
the last visited time AND the visitedCount.

• WebHistory.cpp: (WebHistory::addItemForURL):

Location:

trunk/WebKit/win

Files:

• ChangeLog (modified) (1 diff)
• WebHistory.cpp (modified) (1 diff)

trunk/WebKit/win/ChangeLog

@@ +1 @@
+2007-07-20  Ada Chan  <adachan@apple.com>
+
+        Reviewed by Steve.
+        
+        <rdar://problem/5350832> History item's visitedCount wasn't updated correctly
+
+        The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
+        really increment the visitedCount of the HistoryItem - because we only increment the count
+        if the last visited time is different.  We should initialize the HistoryItem with
+        lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
+        the last visited time AND the visitedCount.
+        
+        * WebHistory.cpp:
+        (WebHistory::addItemForURL):
+
 2007-07-20  Oliver Hunt  <oliver@apple.com>
 

trunk/WebKit/win/WebHistory.cpp

@@ -663 +663 @@
         return E_FAIL;
 
-    HRESULT hr = item->initWithURLString(url, title, lastVisited);
+    HRESULT hr = item->initWithURLString(url, title, 0);
     if (FAILED(hr))
         return hr;