Changeset 245142 in webkit

Timestamp:

May 9, 2019, 10:14:06 AM (7 years ago)

Author:

Brent Fulgham

Message:

Correct delayed load event handling
​https://bugs.webkit.org/show_bug.cgi?id=197679
<rdar://problem/50423334>

Reviewed by Alex Christensen.

We need to properly account for the fact that JavaScript might run
while performing loads.

• dom/Document.cpp:

(WebCore::Document::loadEventDelayTimerFired):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Correct delayed load event handling
+        https://bugs.webkit.org/show_bug.cgi?id=197679
+        <rdar://problem/50423334>
+
+        Reviewed by Alex Christensen.
+
+        We need to properly account for the fact that JavaScript might run
+        while performing loads.
+
+        * dom/Document.cpp:
+        (WebCore::Document::loadEventDelayTimerFired):
+
 2019-05-09  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -6301 +6301 @@
     // FIXME: Not obvious why checkCompleted needs to go first. The order these are called is
     // visible to WebKit clients, but it's more like a race than a well-defined relationship.
-    auto weakThis = makeWeakPtr(this);
+    Ref<Document> protectedThis(*this);
     checkCompleted();
-    if (weakThis) {
-        if (auto* frame = this->frame())
-            frame->loader().checkLoadComplete();
-    }
+    if (auto* frame = this->frame())
+        frame->loader().checkLoadComplete();
 }