Changeset 245234 in webkit

Timestamp:

May 13, 2019, 8:39:31 AM (7 years ago)

Author:

Michael Catanzaro

Message:

Unreviewed, fix unused variable warnings in release builds

Source/WebKit:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearWebProcessHasUploads):

Source/WTF:

• wtf/URLHelpers.cpp:

(WTF::URLHelpers::escapeUnsafeCharacters):

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/URLHelpers.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/WebProcessPool.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, fix unused variable warnings in release builds
+
+        * wtf/URLHelpers.cpp:
+        (WTF::URLHelpers::escapeUnsafeCharacters):
+
 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/WTF/wtf/URLHelpers.cpp

@@ -771 +771 @@
             size_t offset = 0;
             UBool failure = false;
-            U8_APPEND(utf8Buffer, offset, 4, c, failure)
-            ASSERT(!failure);
+            U8_APPEND(utf8Buffer, offset, 4, c, failure);
+            ASSERT_UNUSED(failure, !failure);
 
             for (size_t j = 0; j < offset; ++j) {

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-13  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Unreviewed, fix unused variable warnings in release builds
+
+        * UIProcess/WebProcessPool.cpp:
+        (WebKit::WebProcessPool::clearWebProcessHasUploads):
+
 2019-05-12  Takashi Komori  <Takashi.Komori@sony.com>
 

trunk/Source/WebKit/UIProcess/WebProcessPool.cpp

@@ -2556 +2556 @@
 
     auto* process = WebProcessProxy::processForIdentifier(processID);
-    ASSERT(process);
+    ASSERT_UNUSED(process, process);
     RELEASE_LOG(ProcessSuspension, "Web process pid %u no longer has uploads in progress", (unsigned)process->processIdentifier());