Changeset 245242 in webkit

Timestamp:

May 13, 2019, 11:13:40 AM (7 years ago)

Author:

Antti Koivisto

Message:

REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=197818
<rdar://problem/50705762>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/ios/event-region-scale-transform-shared.html

fast/scrolling/ios/event-region-translate-transform-shared.html

This fixes the assert. However the added tests demonstrate that transform is not taken into account
when computing the event region, ​https://bugs.webkit.org/show_bug.cgi?id=197836.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

LayoutTests:

• fast/scrolling/ios/event-region-scale-transform-shared-expected.txt: Added.
• fast/scrolling/ios/event-region-scale-transform-shared.html: Added.
• fast/scrolling/ios/event-region-translate-transform-shared-expected.txt: Added.
• fast/scrolling/ios/event-region-translate-transform-shared.html: Added.
• platform/ios-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/event-region-scale-transform-shared-expected.txt (added)
• LayoutTests/fast/scrolling/ios/event-region-scale-transform-shared.html (added)
• LayoutTests/fast/scrolling/ios/event-region-translate-transform-shared-expected.txt (added)
• LayoutTests/fast/scrolling/ios/event-region-translate-transform-shared.html (added)
• LayoutTests/platform/ios-wk2/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-13  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
+        https://bugs.webkit.org/show_bug.cgi?id=197818
+        <rdar://problem/50705762>
+
+        Reviewed by Simon Fraser.
+
+        * fast/scrolling/ios/event-region-scale-transform-shared-expected.txt: Added.
+        * fast/scrolling/ios/event-region-scale-transform-shared.html: Added.
+        * fast/scrolling/ios/event-region-translate-transform-shared-expected.txt: Added.
+        * fast/scrolling/ios/event-region-translate-transform-shared.html: Added.
+        * platform/ios-wk2/TestExpectations:
+
 2019-05-13  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -1316 +1316 @@
 webkit.org/b/196013 fast/scrolling/rubber-band-shows-background.html [ ImageOnlyFailure ]
 
-webkit.org/b/197818 compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html [ Skip ]
-
 webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html [ Pass Timeout ]
 webkit.org/b/196269 http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html [ Pass Timeout ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-13  Antti Koivisto  <antti@apple.com>
+
+        REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
+        https://bugs.webkit.org/show_bug.cgi?id=197818
+        <rdar://problem/50705762>
+
+        Reviewed by Simon Fraser.
+
+        Tests: fast/scrolling/ios/event-region-scale-transform-shared.html
+               fast/scrolling/ios/event-region-translate-transform-shared.html
+
+        This fixes the assert. However the added tests demonstrate that transform is not taken into account
+        when computing the event region, https://bugs.webkit.org/show_bug.cgi?id=197836.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateEventRegion):
+
 2019-05-13  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1490 +1490 @@
     m_owningLayer.paintLayerContents(nullContext, paintingInfo, paintFlags);
 
-    for (auto& layerWeakPtr : m_backingSharingLayers)
-        layerWeakPtr->paintLayerContents(nullContext, paintingInfo, paintFlags);
+    for (auto& layer : m_backingSharingLayers)
+        layer->paintLayerWithEffects(nullContext, paintingInfo, paintFlags);
 
     auto contentOffset = roundedIntSize(contentOffsetInCompositingLayer());