Changeset 245282 in webkit

Timestamp:

May 14, 2019, 9:18:24 AM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Status bubble should turn orange when any build step fails
​https://bugs.webkit.org/show_bug.cgi?id=197812

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
(StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -72 +72 @@
 
         if build.result is None:  # In-progress build
-            bubble['state'] = 'started'
+            if self._does_build_contains_any_failed_step(build):
+                bubble['state'] = 'provisional-fail'
+            else:
+                bubble['state'] = 'started'
             bubble['details_message'] = 'Build is in-progress. Recent messages:\n\n' + self._steps_messages(build)
         elif build.result == Buildbot.SUCCESS:
@@ -151 +154 @@
         return not filter(lambda step_to_hide: re.search(step_to_hide, step.state_string), StatusBubble.STEPS_TO_HIDE)
 
+    def _does_build_contains_any_failed_step(self, build):
+        for step in build.step_set.all():
+            if step.result and step.result != Buildbot.SUCCESS:
+                return True
+        return False
+
     def _most_recent_step_message(self, build):
         recent_step = build.step_set.last()

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-14  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Status bubble should turn orange when any build step fails
+        https://bugs.webkit.org/show_bug.cgi?id=197812
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
+        (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
+
 2019-05-14  Alex Christensen  <achristensen@webkit.org>