Changeset 245310 in webkit

Timestamp:

May 14, 2019, 2:08:02 PM (7 years ago)

Author:

Alan Coon

Message:

Cherry-pick r245298. rdar://problem/50665984

Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
​https://bugs.webkit.org/show_bug.cgi?id=197883
<rdar://problem/50665984>

Reviewed by Alex Christensen.

Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
delegates and those may cause |this| to get destroyed.

• UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didBecomeUnresponsive): (WebKit::WebProcessProxy::didExceedCPULimit):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608.1.24-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebProcessProxy.cpp (modified) (2 diffs)

branches/safari-608.1.24-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-14  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r245298. rdar://problem/50665984
+
+    Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
+    https://bugs.webkit.org/show_bug.cgi?id=197883
+    <rdar://problem/50665984>
+    
+    Reviewed by Alex Christensen.
+    
+    Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
+    delegates and those may cause |this| to get destroyed.
+    
+    * UIProcess/WebProcessProxy.cpp:
+    (WebKit::WebProcessProxy::didBecomeUnresponsive):
+    (WebKit::WebProcessProxy::didExceedCPULimit):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-05-14  Chris Dumez  <cdumez@apple.com>
+
+            Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
+            https://bugs.webkit.org/show_bug.cgi?id=197883
+            <rdar://problem/50665984>
+
+            Reviewed by Alex Christensen.
+
+            Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
+            delegates and those may cause |this| to get destroyed.
+
+            * UIProcess/WebProcessProxy.cpp:
+            (WebKit::WebProcessProxy::didBecomeUnresponsive):
+            (WebKit::WebProcessProxy::didExceedCPULimit):
+
 2019-05-14  Alan Coon  <alancoon@apple.com>
 

branches/safari-608.1.24-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp

@@ -714 +714 @@
 void WebProcessProxy::didBecomeUnresponsive()
 {
+    auto protectedThis = makeRef(*this);
+
     m_isResponsive = NoOrMaybe::No;
 
@@ -1315 +1317 @@
 void WebProcessProxy::didExceedCPULimit()
 {
+    auto protectedThis = makeRef(*this);
+
     for (auto& page : pages()) {
         if (page->isPlayingAudio()) {