Changeset 245419 in webkit

Timestamp:

May 16, 2019, 4:24:10 PM (7 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
<​https://webkit.org/b/197965>

Reviewed by Joseph Pecoraro.

• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(WTR::TestRunner::pathToLocalResource): Don't call
JSStringRetain() here because the JSRetainPtr<JSStringRef>
return type will increment the retain count for us.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-16  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
+        <https://webkit.org/b/197965>
+
+        Reviewed by Joseph Pecoraro.
+
+        * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
+        (WTR::TestRunner::pathToLocalResource): Don't call
+        JSStringRetain() here because the JSRetainPtr<JSStringRef>
+        return type will increment the retain count for us.
+
 2019-05-16  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm

@@ -39 +39 @@
 JSRetainPtr<JSStringRef> TestRunner::pathToLocalResource(JSStringRef url)
 {
-    return JSStringRetain(url); // Do nothing on mac.
+    return url; // Do nothing on Cocoa.
 }