Changeset 245469 in webkit

Timestamp:

May 17, 2019, 10:26:05 AM (7 years ago)

Author:

Said Abou-Hallawa

Message:

SVGElement should detach itself from all its properties before it is deleted
​https://bugs.webkit.org/show_bug.cgi?id=197954

Reviewed by Simon Fraser.

Source/WebCore:

Before deleting the SVGElement node, SVGElement::detachAllProperties()
needs to be called. This will make the properties be detached objects
which means no change will be committed unless these properties are
attached to another owner.

Test: svg/dom/svg-properties-detach-change.html

• dom/Node.cpp:

(WebCore::Node::removedLastRef):

• svg/SVGElement.h:

(WebCore::SVGElement::detachAllProperties):

LayoutTests:

• svg/dom/svg-properties-detach-change-expected.txt: Added.
• svg/dom/svg-properties-detach-change.html : Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/dom/svg-properties-detach-change-expected.txt (added)
• LayoutTests/svg/dom/svg-properties-detach-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Node.cpp (modified) (2 diffs)
• Source/WebCore/svg/SVGElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-16  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        SVGElement should detach itself from all its properties before it is deleted
+        https://bugs.webkit.org/show_bug.cgi?id=197954
+
+        Reviewed by Simon Fraser.
+
+        * svg/dom/svg-properties-detach-change-expected.txt: Added.
+        * svg/dom/svg-properties-detach-change.html : Added.
+
 2019-05-17  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-16  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        SVGElement should detach itself from all its properties before it is deleted
+        https://bugs.webkit.org/show_bug.cgi?id=197954
+
+        Reviewed by Simon Fraser.
+
+        Before deleting the SVGElement node, SVGElement::detachAllProperties()
+        needs to be called. This will make the properties be detached objects
+        which means no change will be committed unless these properties are
+        attached to another owner.
+
+        Test: svg/dom/svg-properties-detach-change.html
+
+        * dom/Node.cpp:
+        (WebCore::Node::removedLastRef):
+        * svg/SVGElement.h:
+        (WebCore::SVGElement::detachAllProperties):
+
 2019-05-17  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/dom/Node.cpp

@@ -63 +63 @@
 #include "RenderTextControl.h"
 #include "RenderView.h"
+#include "SVGElement.h"
 #include "ScopedEventQueue.h"
 #include "ScriptDisallowedScope.h"
@@ -2510 +2511 @@
     }
 
+    // Now it is time to detach the SVGElement from all its properties. These properties
+    // may outlive the SVGElement. The only difference after the detach is no commit will
+    // be carried out unless these properties are attached to another owner.
+    if (is<SVGElement>(*this))
+        downcast<SVGElement>(*this).detachAllProperties();
+
 #ifndef NDEBUG
     m_deletionHasBegun = true;

trunk/Source/WebCore/svg/SVGElement.h

@@ -129 +129 @@
     using PropertyRegistry = SVGPropertyOwnerRegistry<SVGElement>;
     virtual const SVGPropertyRegistry& propertyRegistry() const { return m_propertyRegistry; }
+    void detachAllProperties() { propertyRegistry().detachAllProperties(); }
 
     bool isAnimatedPropertyAttribute(const QualifiedName&) const;