Changeset 245506 in webkit

Timestamp:

May 19, 2019, 2:37:44 PM (7 years ago)

Author:

graouts@webkit.org

Message:

[Pointer Events] The pointerup, pointerout and pointerleave events may be fired twice
​https://bugs.webkit.org/show_bug.cgi?id=198028
<rdar://problem/50769425>

Reviewed by Dean Jackson.

Add a new test that checks that we're firing a "pointermove" event when the touch pressure
changes, even when the touch is stationary, and that a single "pointerup" event is fired
as the touch ends and the pressure changes. The relevant code change is done in WebKitAdditions.

• pointerevents/ios/pressure-change-expected.txt: Added.
• pointerevents/ios/pressure-change.html: Added.
• pointerevents/utils.js:

(prototype._handlePointerEvent):
(prototype.stationary):
(prototype._action):

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• pointerevents/ios/pressure-change-expected.txt (added)
• pointerevents/ios/pressure-change.html (added)
• pointerevents/utils.js (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-19  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] The pointerup, pointerout and pointerleave events may be fired twice
+        https://bugs.webkit.org/show_bug.cgi?id=198028
+        <rdar://problem/50769425>
+
+        Reviewed by Dean Jackson.
+
+        Add a new test that checks that we're firing a "pointermove" event when the touch pressure
+        changes, even when the touch is stationary, and that a single "pointerup" event is fired
+        as the touch ends and the pressure changes. The relevant code change is done in WebKitAdditions.
+
+        * pointerevents/ios/pressure-change-expected.txt: Added.
+        * pointerevents/ios/pressure-change.html: Added.
+        * pointerevents/utils.js:
+        (prototype._handlePointerEvent):
+        (prototype.stationary):
+        (prototype._action):
+
 2019-05-19  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/pointerevents/utils.js

@@ -68 +68 @@
             x: event.clientX,
             y: event.clientY,
+            pressure: event.pressure,
             isPrimary: event.isPrimary,
             isTrusted: event.isTrusted
@@ -238 +239 @@
     stationary(options)
     {
-        return this._action("stationary", options.x || 0, options.y || 0);
-    }
-
-    _action(phase, x, y)
+        return this._action("stationary", options.x || this._lastX, options.y || this._lastY, options.pressure || 0);
+    }
+
+    _action(phase, x, y, pressure = 0)
     {
         this._lastX = x;
         this._lastY = y;
-        return { inputType: "finger", id: this.id, phase, x, y };
+        return { inputType: "finger", id: this.id, phase, x, y, pressure };
     }