Changeset 245659 in webkit

Timestamp:

May 22, 2019, 4:46:28 PM (7 years ago)

Author:

Simon Fraser

Message:

<rdar://problem/50058173> REGRESSION (r243347) Layout tests fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on* are failing

Unreviewed test gardening.

I confirmed that “cancelable” is no longer true because
WebPageProxy::handleTouchEventSynchronously() is dispatching the events
asynchronously, so setCanPreventNativeGestures is set to false.

The exception is because the “touchEnd” event has no touches.

• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt:
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html:
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt:
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt (modified) (1 diff)
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html (modified) (1 diff)
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt (modified) (1 diff)
• fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-22  Simon Fraser  <simon.fraser@apple.com>
+
+        <rdar://problem/50058173> REGRESSION (r243347) Layout tests fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on* are failing
+
+        Unreviewed test gardening.
+
+        I confirmed that “cancelable” is no longer true because
+        WebPageProxy::handleTouchEventSynchronously() is dispatching the events
+        asynchronously, so setCanPreventNativeGestures is set to false.
+
+        The exception is because the “touchEnd” event has no touches.
+
+        * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt:
+        * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html:
+        * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt:
+        * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html:
+
 2019-05-22  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt

@@ -11 +11 @@
 PASS document.getElementById('eventTarget').scrollTop is 0
 PASS document.getElementById('eventTarget').scrollLeft is 0
-Received cancelable event touchstart at 50, 150
-Received cancelable event touchmove at 50, 50
+Received event touchstart at 50, 150
+Received event touchmove at 50, 50
+Received event touchend
+Dispatched Drag
 PASS window.scrollX is 0
 PASS window.scrollY is 0

trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html

@@ -46 +46 @@
 
             function touchEventHandler(event) {
-                debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+                if (event.touches.length)
+                    debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+                else
+                    debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type);
             }
             eventTarget.addEventListener('touchstart', touchEventHandler, { 'passive': true });

trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt

@@ -11 +11 @@
 PASS document.getElementById('eventTarget').scrollTop is 0
 PASS document.getElementById('eventTarget').scrollLeft is 0
-Received cancelable event touchstart at 50, 150
-Received cancelable event touchmove at 50, 50
+Received event touchstart at 50, 150
+Received event touchmove at 50, 50
+Received event touchend
+Dispatched Drag
 PASS window.scrollX is 0
 PASS window.scrollY is 0

trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html

@@ -46 +46 @@
 
             function touchEventHandler(event) {
-                debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+                if (event.touches.length)
+                    debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+                else
+                    debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type);
             }
             document.addEventListener('touchstart', touchEventHandler, { 'passive': true });