Changeset 245696 in webkit

Timestamp:

May 23, 2019, 11:04:49 AM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: clicking a source link should never open the Network tab
​https://bugs.webkit.org/show_bug.cgi?id=197951

Reviewed by Timothy Hatcher.

The preview panel in the Network tab is really meant to be just that; a preview.

Opening resources in the preview panel is not a great experience, as the Network tab doesn't
have as much of the information one would expect when viewing a resource (namely the
Resource details sidebar panel).

Navigating within the Network tab also completely wipes out the current "state" of what
you're looking at (e.g. which panel), which could be unexpected.

The only way this could happen previously was if the Resources/Debugger/Sources tabs had
never been active at any point in the past. Selecting one of those tabs and then clicking on
an initiator link in the Network tab would re-select that other tab.

• UserInterface/Base/Main.js:

(WI.dialogWasDismissedWithRepresentedObject):

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (1 diff)
• UserInterface/Views/ResourceHeadersContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-05-23  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: clicking a source link should never open the Network tab
+        https://bugs.webkit.org/show_bug.cgi?id=197951
+
+        Reviewed by Timothy Hatcher.
+
+        The preview panel in the Network tab is really meant to be just that; a preview.
+
+        Opening resources in the preview panel is not a great experience, as the Network tab doesn't
+        have as much of the information one would expect when viewing a resource (namely the
+        Resource details sidebar panel).
+
+        Navigating within the Network tab also completely wipes out the current "state" of what
+        you're looking at (e.g. which panel), which could be unexpected.
+
+        The only way this could happen previously was if the Resources/Debugger/Sources tabs had
+        never been active at any point in the past. Selecting one of those tabs and then clicking on
+        an initiator link in the Network tab would re-select that other tab.
+
+        * UserInterface/Base/Main.js:
+        (WI.dialogWasDismissedWithRepresentedObject):
+
+        * UserInterface/Views/ResourceHeadersContentView.js:
+        (WI.ResourceHeadersContentView.prototype._refreshSummarySection):
+
 2019-05-22  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -3236 +3236 @@
         return;
 
-    WI.showRepresentedObject(representedObject, dialog.cookie);
+    WI.showRepresentedObject(representedObject, dialog.cookie, {
+        ignoreSearchTab: true,
+        ignoreNetworkTab: true,
+    });
 };
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js

@@ -271 +271 @@
                 dontFloat: true,
                 ignoreSearchTab: true,
+                ignoreNetworkTab: true,
             };
             let link = WI.createSourceCodeLocationLink(initiatorLocation, options);
@@ -284 +285 @@
                     if (!this._popover) {
                         this._popover = new WI.Popover(this);
-                        this._popover.windowResizeHandler = () => { this._presentPopoverBelowCallStackElement() };
+                        this._popover.windowResizeHandler = () => { this._presentPopoverBelowCallStackElement(); };
                     }