Changeset 245699 in webkit

Timestamp:

May 23, 2019, 11:13:56 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[Pointer Events] Compatibility mouse events can only be prevented while the pointer is pressed
​https://bugs.webkit.org/show_bug.cgi?id=198178

Patch by Antoine Quint <Antoine Quint> on 2019-05-23
Reviewed by Dean Jackson.

Source/WebCore:

Test: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html

The Pointer Events spec, in ​https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events, says that "Mouse events
can only be prevented when the pointer is down. Hovering pointers (e.g. a mouse with no buttons pressed) cannot have their mouse
events prevented." We now track whether the pointer is pressed and clear the preventsCompatibilityMouseEvents when the pointer is
moved and it is not pressed.

• page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::pointerEventWasDispatched):

• page/PointerCaptureController.h:

LayoutTests:

Add a test that listens "mousemove" events and checks it is not dispatched after preventDefault() is called when handling

"pointerdown" but it is dispatched after releasing the mouse pointer and moving it again.

• pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released-expected.txt: Added.
• pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released-expected.txt (added)
• LayoutTests/pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/PointerCaptureController.cpp (modified) (1 diff)
• Source/WebCore/page/PointerCaptureController.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-23  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] Compatibility mouse events can only be prevented while the pointer is pressed
+        https://bugs.webkit.org/show_bug.cgi?id=198178
+
+        Reviewed by Dean Jackson.
+
+        Add a test that listens "mousemove" events and checks it is not dispatched after preventDefault() is called when handling
+         "pointerdown" but it is dispatched after releasing the mouse pointer and moving it again.
+
+        * pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released-expected.txt: Added.
+        * pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html: Added.
+
 2019-05-23  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-23  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] Compatibility mouse events can only be prevented while the pointer is pressed
+        https://bugs.webkit.org/show_bug.cgi?id=198178
+
+        Reviewed by Dean Jackson.
+
+        Test: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html
+
+        The Pointer Events spec, in https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events, says that "Mouse events
+        can only be prevented when the pointer is down. Hovering pointers (e.g. a mouse with no buttons pressed) cannot have their mouse
+        events prevented." We now track whether the pointer is pressed and clear the preventsCompatibilityMouseEvents when the pointer is
+        moved and it is not pressed.
+
+        * page/PointerCaptureController.cpp:
+        (WebCore::PointerCaptureController::pointerEventWasDispatched):
+        * page/PointerCaptureController.h:
+
 2019-05-23  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/page/PointerCaptureController.cpp

@@ -265 +265 @@
         // Pointer Capture steps to fire lostpointercapture if necessary.
         // https://w3c.github.io/pointerevents/#implicit-release-of-pointer-capture
-        if (event.type() == eventNames().pointerupEvent)
+        if (event.type() == eventNames().pointerupEvent) {
             capturingData.pendingTargetOverride = nullptr;
+            capturingData.pointerIsPressed = false;
+        }
+
+        // If a mouse pointer has moved while it isn't pressed, make sure we reset the preventsCompatibilityMouseEvents flag since
+        // we could otherwise prevent compatibility mouse events while those are only supposed to be prevented while the pointer is pressed.
+        if (event.type() == eventNames().pointermoveEvent && capturingData.pointerType == PointerEvent::mousePointerType() && !capturingData.pointerIsPressed)
+            capturingData.preventsCompatibilityMouseEvents = false;
 
         // If the pointer event dispatched was pointerdown and the event was canceled, then set the PREVENT MOUSE EVENT flag for this pointerType.
         // https://www.w3.org/TR/pointerevents/#mapping-for-devices-that-support-hover
-        if (event.type() == eventNames().pointerdownEvent)
+        if (event.type() == eventNames().pointerdownEvent) {
             capturingData.preventsCompatibilityMouseEvents = event.defaultPrevented();
+            capturingData.pointerIsPressed = true;
+        }
     }
 

trunk/Source/WebCore/page/PointerCaptureController.h

@@ -67 +67 @@
         bool isPrimary { false };
         bool preventsCompatibilityMouseEvents { false };
+        bool pointerIsPressed { false };
     };