Changeset 245721 in webkit

Timestamp:

May 23, 2019, 3:21:04 PM (7 years ago)

Author:

sbarati@apple.com

Message:

[WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues
​https://bugs.webkit.org/show_bug.cgi?id=198193

Reviewed by Myles Maxfield.

Source/WebCore:

We were only transforming the top most node in the AST. So things like
'x = foo.bar' would work, but 'x = foo.bar.baz' would not.

Test: webgpu/whlsl-nested-dot-expression-rvalue.html

• Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:

(WebCore::WHLSL::PropertyResolver::simplifyRightValue):

LayoutTests:

• webgpu/whlsl-nested-dot-expression-rvalue-expected.html: Added.
• webgpu/whlsl-nested-dot-expression-rvalue.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue-expected.html (added)
• LayoutTests/webgpu/whlsl-nested-dot-expression-rvalue.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-23  Saam barati  <sbarati@apple.com>
+
+        [WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues
+        https://bugs.webkit.org/show_bug.cgi?id=198193
+
+        Reviewed by Myles Maxfield.
+
+        * webgpu/whlsl-nested-dot-expression-rvalue-expected.html: Added.
+        * webgpu/whlsl-nested-dot-expression-rvalue.html: Added.
+
 2019-05-23  Shawn Roberts  <sroberts@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-23  Saam barati  <sbarati@apple.com>
+
+        [WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues
+        https://bugs.webkit.org/show_bug.cgi?id=198193
+
+        Reviewed by Myles Maxfield.
+
+        We were only transforming the top most node in the AST. So things like
+        'x = foo.bar' would work, but 'x = foo.bar.baz' would not.
+
+        Test: webgpu/whlsl-nested-dot-expression-rvalue.html
+
+        * Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
+        (WebCore::WHLSL::PropertyResolver::simplifyRightValue):
+
 2019-05-22  Stephanie Lewis  <slewis@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp

@@ -590 +590 @@
     Lexer::Token origin = dotExpression.origin();
 
+    checkErrorAndVisit(dotExpression.base());
+
     if (auto* anderFunction = dotExpression.anderFunction()) {
         auto& base = dotExpression.base();