Changeset 245724 in webkit

Timestamp:

May 23, 2019, 4:13:45 PM (7 years ago)

Author:

sbarati@apple.com

Message:

[WHLSL] Don't wrap anonymous variables in parens in the AST dumper
​https://bugs.webkit.org/show_bug.cgi?id=198196

Reviewed by Myles C. Maxfield.

This makes the dump of 'foo.bar.x = 42' go from
($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));

to:
($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));

• Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:

(WebCore::WHLSL::ASTDumper::visit):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/WHLSLASTDumper.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-23  Saam barati  <sbarati@apple.com>
+
+        [WHLSL] Don't wrap anonymous variables in parens in the AST dumper
+        https://bugs.webkit.org/show_bug.cgi?id=198196
+
+        Reviewed by Myles C. Maxfield.
+
+        This makes the dump of 'foo.bar.x = 42' go from
+        ($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));
+        
+        to:
+        ($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));
+
+        * Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
+        (WebCore::WHLSL::ASTDumper::visit):
+
 2019-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp

@@ -637 +637 @@
 {
     if (variableReference.name().isEmpty())
-        m_out.print("$(", RawPointer(variableReference.variable()), ")");
+        m_out.print("$", RawPointer(variableReference.variable()));
     else
         m_out.print(variableReference.name());