Changeset 245727 in webkit

Timestamp:

May 23, 2019, 4:41:56 PM (7 years ago)

Author:

sbarati@apple.com

Message:

[WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction
​https://bugs.webkit.org/show_bug.cgi?id=198199

Reviewed by Myles C. Maxfield.

We would dump "*foo.bar" for "(*foo).bar", which is super confusing.
We now dump "(*foo).bar".

• Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:

(WebCore::WHLSL::ASTDumper::visit):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/WHLSLASTDumper.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-23  Saam barati  <sbarati@apple.com>
+
+        [WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction
+        https://bugs.webkit.org/show_bug.cgi?id=198199
+
+        Reviewed by Myles C. Maxfield.
+
+        We would dump "*foo.bar" for "(*foo).bar", which is super confusing.
+        We now dump "(*foo).bar".
+
+        * Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
+        (WebCore::WHLSL::ASTDumper::visit):
+
 2019-05-23  Saam barati  <sbarati@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp

@@ -420 +420 @@
 void ASTDumper::visit(AST::Expression& expression)
 {
+    bool skipParens = is<AST::BooleanLiteral>(expression)
+        || is<AST::FloatLiteral>(expression)
+        || is<AST::IntegerLiteral>(expression)
+        || is<AST::NullLiteral>(expression)
+        || is<AST::UnsignedIntegerLiteral>(expression)
+        || is<AST::EnumerationMemberLiteral>(expression)
+        || is<AST::CommaExpression>(expression)
+        || is<AST::VariableReference>(expression);
+
+    if (!skipParens)
+        m_out.print("(");
     Base::visit(expression);
+    if (!skipParens)
+        m_out.print(")");
 }