Changeset 245748 in webkit

Timestamp:

May 24, 2019, 11:26:45 AM (7 years ago)

Author:

youenn@apple.com

Message:

Make sure completion handler is always called in SWServer::startSuspension
​https://bugs.webkit.org/show_bug.cgi?id=198215

Reviewed by Alex Christensen.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::startSuspension):
Make sure completion handler is called in case of no registration store.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/service/server/SWServer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-24  Youenn Fablet  <youenn@apple.com>
+
+        Make sure completion handler is always called in SWServer::startSuspension
+        https://bugs.webkit.org/show_bug.cgi?id=198215
+
+        Reviewed by Alex Christensen.
+
+        * workers/service/server/SWServer.cpp:
+        (WebCore::SWServer::startSuspension):
+        Make sure completion handler is called in case of no registration store.
+
 2019-05-24  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/workers/service/server/SWServer.cpp

@@ -221 +221 @@
 void SWServer::startSuspension(CompletionHandler<void()>&& completionHandler)
 {
-    if (m_registrationStore)
-        m_registrationStore->startSuspension(WTFMove(completionHandler));
+    if (!m_registrationStore) {
+        completionHandler();
+        return;
+    }
+    m_registrationStore->startSuspension(WTFMove(completionHandler));
 }