Changeset 245750 in webkit

Timestamp:

May 24, 2019, 12:01:48 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
​https://bugs.webkit.org/show_bug.cgi?id=198221

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createGeneralSettingsView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-05-24  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
+        https://bugs.webkit.org/show_bug.cgi?id=198221
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
+
 2019-05-23  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -223 +223 @@
         generalSettingsView.addSeparator();
 
-        generalSettingsView.addSetting(WI.UIString("Element Selection:"), WI.settings.showRulersDuringElementSelection, WI.UIString("Show page rulers and node border lines"));
-
-        generalSettingsView.addSeparator();
+        if (InspectorBackend.domains.DOM && InspectorBackend.domains.DOM.setInspectModeEnabled && InspectorBackend.domains.DOM.setInspectModeEnabled.supports("showRulers")) {
+            generalSettingsView.addSetting(WI.UIString("Element Selection:"), WI.settings.showRulersDuringElementSelection, WI.UIString("Show page rulers and node border lines"));
+
+            generalSettingsView.addSeparator();
+        }
 
         const zoomLevels = [0.6, 0.8, 1, 1.2, 1.4, 1.6, 1.8, 2, 2.2, 2.4];