Changeset 245757 in webkit

Timestamp:

May 24, 2019, 3:48:26 PM (7 years ago)

Author:

pvollan@apple.com

Message:

Remove unused member in WebsiteDataRecord
​https://bugs.webkit.org/show_bug.cgi?id=198231

Reviewed by Brent Fulgham.

The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins
with credentials are now stored in the 'origins' member.

• UIProcess/WebsiteData/WebsiteDataRecord.cpp:

(WebKit::WebsiteDataRecord::addOriginWithCredential): Deleted.

• UIProcess/WebsiteData/WebsiteDataRecord.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebsiteData/WebsiteDataRecord.cpp (modified) (1 diff)
• UIProcess/WebsiteData/WebsiteDataRecord.h (modified) (2 diffs)
• UIProcess/WebsiteData/WebsiteDataStore.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-24  Per Arne Vollan  <pvollan@apple.com>
+
+        Remove unused member in WebsiteDataRecord
+        https://bugs.webkit.org/show_bug.cgi?id=198231
+
+        Reviewed by Brent Fulgham.
+
+        The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins
+        with credentials are now stored in the 'origins' member.
+
+        * UIProcess/WebsiteData/WebsiteDataRecord.cpp:
+        (WebKit::WebsiteDataRecord::addOriginWithCredential): Deleted.
+        * UIProcess/WebsiteData/WebsiteDataRecord.h:
+        * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+        (WebKit::WebsiteDataStore::fetchDataAndApply):
+
 2019-05-24  David Quesada  <david_quesada@apple.com>
 

trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp

@@ -154 +154 @@
 }
 
-void WebsiteDataRecord::addOriginWithCredential(const String& origin)
-{
-    types.add(WebsiteDataType::Credentials);
-    originsWithCredentials.add(origin);
 }
-
-}

trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h

@@ -54 +54 @@
     void addPluginDataHostName(const String& hostName);
 #endif
-    void addOriginWithCredential(const String&);
     void addHSTSCacheHostname(const String& hostName);
 
@@ -71 +70 @@
     HashSet<String> pluginDataHostNames;
 #endif
-    HashSet<String> originsWithCredentials;
     HashSet<String> HSTSCacheHostNames;
 

trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp

@@ -320 +320 @@
 #endif
 
-            for (auto& origin : websiteData.originsWithCredentials) {
-                auto displayName = WebsiteDataRecord::displayNameForOrigin(WebCore::SecurityOriginData::fromURL(URL(URL(), origin)));
-                ASSERT(!displayName.isEmpty());
-
-                auto& record = m_websiteDataRecords.add(displayName, WebsiteDataRecord { }).iterator->value;
-                if (!record.displayName)
-                    record.displayName = WTFMove(displayName);
-
-                record.addOriginWithCredential(origin);
-            }
-
             for (auto& hostName : websiteData.hostNamesWithHSTSCache) {
                 auto displayName = WebsiteDataRecord::displayNameForHostName(hostName);