Changeset 245795 in webkit

Timestamp:

May 27, 2019, 9:19:06 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[Pointer Events] Test at pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html times out
​https://bugs.webkit.org/show_bug.cgi?id=198275
<rdar://problem/50618496>

Patch by Antoine Quint <Antoine Quint> on 2019-05-27
Reviewed by Antti Koivisto.

Only WKCompositingView instances may have associated touch-action data, so we should filter out any hit-testing view
that isn't a WKCompositingView when finding the view that should hit-test when looking for touch-action information.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(WebKit::touchActionsForPoint):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-27  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] Test at pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html times out
+        https://bugs.webkit.org/show_bug.cgi?id=198275
+        <rdar://problem/50618496>
+
+        Reviewed by Antti Koivisto.
+
+        Only WKCompositingView instances may have associated touch-action data, so we should filter out any hit-testing view
+        that isn't a WKCompositingView when finding the view that should hit-test when looking for touch-action information.
+
+        * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
+        (WebKit::touchActionsForPoint):
+
 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm

@@ -99 +99 @@
         return { WebCore::TouchAction::Auto };
 
-    auto *hitView = viewsAtPoint.last();
+    UIView *hitView;
+    for (auto *view : WTF::makeReversedRange(viewsAtPoint)) {
+        if ([view isKindOfClass:[WKCompositingView class]]) {
+            hitView = view;
+            break;
+        }
+    }
+
+    if (!hitView)
+        return { WebCore::TouchAction::Auto };
 
     CGPoint hitViewPoint = [hitView convertPoint:point fromView:rootView];