Changeset 245821 in webkit

Timestamp:

May 28, 2019, 12:10:23 PM (7 years ago)

Author:

Devin Rousso

Message:

REGRESSION (r244182): inspector/canvas/recording-webgl-snapshots.html became flaky on WK1
​https://bugs.webkit.org/show_bug.cgi?id=196875
<rdar://problem/49873252>

Reviewed by Said Abou-Hallawa.

Remove the frameLimit configuration on these tests, as they're short enough that when
running in debug, the timing between the InspectorCanvasAgent automatically stopping the
recording and the test page's LastFrame event (which will manually stop the recording) is
too close and can result in a race condition.

Instead, just wait for the test page to say "done" (LastFrame) before stopping the
recording, ensuring that the full "flow" of the recording is under the control of the test.

This isn't an issue when using Web Inspector "normally" (e.g. not in a test), because the
frontend UI will "ignore" these types of errors, not to mention it would be much harder for
a person to get the timing just right to even encounter this situation.

• inspector/canvas/recording-webgl-snapshots.html:
• inspector/canvas/recording-webgl2-snapshots.html:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/canvas/recording-webgl-snapshots.html (modified) (1 diff)
• inspector/canvas/recording-webgl2-snapshots.html (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-28  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION (r244182): inspector/canvas/recording-webgl-snapshots.html became flaky on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=196875
+        <rdar://problem/49873252>
+
+        Reviewed by Said Abou-Hallawa.
+
+        Remove the `frameLimit` configuration on these tests, as they're short enough that when
+        running in debug, the timing between the `InspectorCanvasAgent` automatically stopping the
+        recording and the test page's `LastFrame` event (which will manually stop the recording) is
+        too close and can result in a race condition.
+
+        Instead, just wait for the test page to say "done" (`LastFrame`) before stopping the
+        recording, ensuring that the full "flow" of the recording is under the control of the test.
+
+        This isn't an issue when using Web Inspector "normally" (e.g. not in a test), because the
+        frontend UI will "ignore" these types of errors, not to mention it would be much harder for
+        a person to get the timing just right to even encounter this situation.
+
+        * inspector/canvas/recording-webgl-snapshots.html:
+        * inspector/canvas/recording-webgl2-snapshots.html:
+        * platform/mac/TestExpectations:
+
 2019-05-28  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html

@@ -101 +101 @@
         description: "Check that the snapshot taken after each visual action is different.",
         test(resolve, reject) {
-            startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {frameCount: 1, checkForContentChange: true});
+            startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {checkForContentChange: true});
         },
         timeout: -1,

trunk/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html

@@ -103 +103 @@
         description: "Check that the snapshot taken after each visual action is different.",
         test(resolve, reject) {
-            startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {frameCount: 1, checkForContentChange: true});
+            startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {checkForContentChange: true});
         },
         timeout: -1,

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1812 +1812 @@
 webkit.org/b/196517 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html [ Skip ]
 
-webkit.org/b/196875 inspector/canvas/recording-webgl-snapshots.html [ Pass Failure ]
-
 webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]