Changeset 245829 in webkit

Timestamp:

May 28, 2019, 4:13:55 PM (7 years ago)

Author:

youenn@apple.com

Message:

createAnswer() SDP Rejected by setLocalDescription()
​https://bugs.webkit.org/show_bug.cgi?id=195930
<rdar://problem/49030489>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Make sure to check packetization mode parameter when matching H264 video codec.

• Source/webrtc/media/base/codec.cc:
• WebKit/0001-fix-195930.patch: Added.

LayoutTests:

• webrtc/h264-packetization-mode-expected.txt: Added.
• webrtc/h264-packetization-mode.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webrtc/h264-packetization-mode-expected.txt (added)
• LayoutTests/webrtc/h264-packetization-mode.html (added)
• Source/ThirdParty/libwebrtc/ChangeLog (modified) (1 diff)
• Source/ThirdParty/libwebrtc/Source/webrtc/media/base/codec.cc (modified) (1 diff)
• Source/ThirdParty/libwebrtc/WebKit/0001-fix-195930.patch (added)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-28  Youenn Fablet  <youenn@apple.com>
+
+        createAnswer() SDP Rejected by setLocalDescription()
+        https://bugs.webkit.org/show_bug.cgi?id=195930
+        <rdar://problem/49030489>
+
+        Reviewed by Eric Carlson.
+
+        * webrtc/h264-packetization-mode-expected.txt: Added.
+        * webrtc/h264-packetization-mode.html: Added.
+
 2019-05-28  Shawn Roberts  <sroberts@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2019-05-28  Youenn Fablet  <youenn@apple.com>
+
+        createAnswer() SDP Rejected by setLocalDescription()
+        https://bugs.webkit.org/show_bug.cgi?id=195930
+        <rdar://problem/49030489>
+
+        Reviewed by Eric Carlson.
+
+        Make sure to check packetization mode parameter when matching H264 video codec.
+
+        * Source/webrtc/media/base/codec.cc:
+        * WebKit/0001-fix-195930.patch: Added.
+
 2019-05-09  Andy Estes  <aestes@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/media/base/codec.cc

@@ -384 +384 @@
   // For every format besides H264 and VP9, comparing names is enough.
   if (absl::EqualsIgnoreCase(name1, kH264CodecName))
-    return webrtc::H264::IsSameH264Profile(params1, params2);
+    return webrtc::H264::IsSameH264Profile(params1, params2) && IsSameH264PacketizationMode(params1, params2);
   if (absl::EqualsIgnoreCase(name1, kVp9CodecName))
     return webrtc::IsSameVP9Profile(params1, params2);