Changeset 245843 in webkit

Timestamp:

May 28, 2019, 8:27:47 PM (7 years ago)

Author:

Justin Michaud

Message:

Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
​https://bugs.webkit.org/show_bug.cgi?id=198322

Reviewed by Saam Barati.

Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-28  Justin Michaud  <justin_michaud@apple.com>
+
+        Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
+        https://bugs.webkit.org/show_bug.cgi?id=198322
+
+        Reviewed by Saam Barati.
+
+        Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
+        the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().
+
+        * Scripts/run-jsc-stress-tests:
+
 2019-05-28  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -1082 +1082 @@
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end
@@ -1100 +1100 @@
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end
@@ -1120 +1120 @@
         run("wasm-no-tls-context", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-no-air", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "--collectContinuously=true", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end
@@ -1146 +1146 @@
       runWithOutputHandler("wasm-no-tls-context", noisyOutputHandler, "../spec-harness.js", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
       runWithOutputHandler("wasm-no-air", noisyOutputHandler, "../spec-harness.js", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", *FTL_OPTIONS)
+      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end