Changeset 245844 in webkit

Timestamp:

May 28, 2019, 9:13:53 PM (7 years ago)

Author:

sbarati@apple.com

Message:

[WHLSL] Type of dereference is the type of the thing we point to, not a pointer to that type
​https://bugs.webkit.org/show_bug.cgi?id=198321

Reviewed by Myles C. Maxfield.

Source/WebCore:

Consider this program:
`
thread int* x;
*x = 42
`

In the Checker, we were saying the type of "*x" was "int*" instead of "int".

Test: webgpu/whlsl-dereference-pointer-should-type-check.html

• Modules/webgpu/WHLSL/WHLSLChecker.cpp:

(WebCore::WHLSL::Checker::visit):

LayoutTests:

• webgpu/whlsl-dereference-pointer-should-type-check-expected.html: Added.
• webgpu/whlsl-dereference-pointer-should-type-check.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check-expected.html (added)
• LayoutTests/webgpu/whlsl-dereference-pointer-should-type-check.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-28  Saam Barati  <sbarati@apple.com>
+
+        [WHLSL] Type of dereference is the type of the thing we point to, not a pointer to that type
+        https://bugs.webkit.org/show_bug.cgi?id=198321
+
+        Reviewed by Myles C. Maxfield.
+
+        * webgpu/whlsl-dereference-pointer-should-type-check-expected.html: Added.
+        * webgpu/whlsl-dereference-pointer-should-type-check.html: Added.
+
 2019-05-28  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-28  Saam Barati  <sbarati@apple.com>
+
+        [WHLSL] Type of dereference is the type of the thing we point to, not a pointer to that type
+        https://bugs.webkit.org/show_bug.cgi?id=198321
+
+        Reviewed by Myles C. Maxfield.
+
+        Consider this program:
+        ```
+        thread int* x;
+        *x = 42
+        ```
+        
+        In the Checker, we were saying the type of "*x" was "int*" instead of "int".
+
+        Test: webgpu/whlsl-dereference-pointer-should-type-check.html
+
+        * Modules/webgpu/WHLSL/WHLSLChecker.cpp:
+        (WebCore::WHLSL::Checker::visit):
+
 2019-05-28  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp

@@ -898 +898 @@
     }
 
-    assignType(dereferenceExpression, pointerType->clone(), AST::LeftValue { pointerType->addressSpace() });
+    assignType(dereferenceExpression, pointerType->elementType().clone(), AST::LeftValue { pointerType->addressSpace() });
 }