Changeset 245853 in webkit

Timestamp:

May 29, 2019, 10:23:16 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Prepend KEY_ to the last key alias in PlatformEventKeyboardGtk
​https://bugs.webkit.org/show_bug.cgi?id=198331

Patch by Ludovico de Nittis <​ludovico.denittis@collabora.com> on 2019-05-29
Reviewed by Michael Catanzaro.

No behavior change.

With the commit
​https://bugs.webkit.org/show_bug.cgi?id=198326
A gdk key slipped away from the renaming.

• platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::modifiersForGdkKeyEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/PlatformKeyboardEventGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-29  Ludovico de Nittis  <ludovico.denittis@collabora.com>
+
+        Prepend KEY_ to the last key alias in PlatformEventKeyboardGtk
+        https://bugs.webkit.org/show_bug.cgi?id=198331
+
+        Reviewed by Michael Catanzaro.
+
+        No behavior change.
+
+        With the commit
+        https://bugs.webkit.org/show_bug.cgi?id=198326
+        A gdk key slipped away from the renaming.
+
+        * platform/gtk/PlatformKeyboardEventGtk.cpp:
+        (WebCore::modifiersForGdkKeyEvent):
+
 2019-05-29  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp

@@ -1331 +1331 @@
 {
     OptionSet<PlatformEvent::Modifier> modifiers;
-    if (event->state & GDK_SHIFT_MASK || event->keyval == GDK_3270_BackTab)
+    if (event->state & GDK_SHIFT_MASK || event->keyval == GDK_KEY_3270_BackTab)
         modifiers.add(PlatformEvent::Modifier::ShiftKey);
     if (event->state & GDK_CONTROL_MASK)