Changeset 245856 in webkit

Timestamp:

May 29, 2019, 11:12:40 AM (7 years ago)

Author:

youenn@apple.com

Message:

Modernize getting proxies of UserMediaCaptureManagerProxy
​https://bugs.webkit.org/show_bug.cgi?id=198336

Reviewed by Eric Carlson.

No change of behavior, use HashMap::get instead of find.

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):
(WebKit::UserMediaCaptureManagerProxy::capabilities):
(WebKit::UserMediaCaptureManagerProxy::setMuted):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp (modified) (5 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-29  Youenn Fablet  <youenn@apple.com>
+
+        Modernize getting proxies of UserMediaCaptureManagerProxy
+        https://bugs.webkit.org/show_bug.cgi?id=198336
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior, use HashMap::get instead of find.
+
+        * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
+        (WebKit::UserMediaCaptureManagerProxy::startProducingData):
+        (WebKit::UserMediaCaptureManagerProxy::stopProducingData):
+        (WebKit::UserMediaCaptureManagerProxy::capabilities):
+        (WebKit::UserMediaCaptureManagerProxy::setMuted):
+        (WebKit::UserMediaCaptureManagerProxy::applyConstraints):
+
 2019-05-29  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

@@ -178 +178 @@
 {
     MESSAGE_CHECK_CONTEXTID(id);
-    auto iter = m_proxies.find(id);
-    if (iter != m_proxies.end())
-        iter->value->source().start();
+    if (auto* proxy = m_proxies.get(id))
+        proxy->source().start();
 }
 
@@ -186 +185 @@
 {
     MESSAGE_CHECK_CONTEXTID(id);
-    auto iter = m_proxies.find(id);
-    if (iter != m_proxies.end())
-        iter->value->source().stop();
+    if (auto* proxy = m_proxies.get(id))
+        proxy->source().stop();
 }
 
@@ -201 +199 @@
     MESSAGE_CHECK_CONTEXTID(id);
     WebCore::RealtimeMediaSourceCapabilities capabilities;
-    auto iter = m_proxies.find(id);
-    if (iter != m_proxies.end())
-        capabilities = iter->value->source().capabilities();
+    if (auto* proxy = m_proxies.get(id))
+        capabilities = proxy->source().capabilities();
     completionHandler(WTFMove(capabilities));
 }
@@ -210 +207 @@
 {
     MESSAGE_CHECK_CONTEXTID(id);
-    auto iter = m_proxies.find(id);
-    if (iter != m_proxies.end())
-        iter->value->source().setMuted(muted);
+    if (auto* proxy = m_proxies.get(id))
+        proxy->source().setMuted(muted);
 }
 
@@ -218 +214 @@
 {
     MESSAGE_CHECK_CONTEXTID(id);
-    auto iter = m_proxies.find(id);
-    if (iter == m_proxies.end())
+    auto* proxy = m_proxies.get(id);
+    if (!proxy)
         return;
 
-    auto& source = iter->value->source();
+    auto& source = proxy->source();
     auto result = source.applyConstraints(constraints);
     if (!result)