Changeset 245861 in webkit

Timestamp:

May 29, 2019, 12:16:35 PM (7 years ago)

Author:

Keith Rollin

Message:

Fix builds that don't use makeWindowFromView
​https://bugs.webkit.org/show_bug.cgi?id=198342
<rdar://problem/51228563>

Reviewed by Wenson Hsieh.

In some configurations, VideoFullscreenInterfaceAVKit.mm declares but
does not use makeWindowFromView. Fix by conditionalizing the the
declaration on the same symbol as point where it's used.

No new tests -- no new functionality.

• platform/ios/VideoFullscreenInterfaceAVKit.mm:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/VideoFullscreenInterfaceAVKit.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-29  Keith Rollin  <krollin@apple.com>
+
+        Fix builds that don't use makeWindowFromView
+        https://bugs.webkit.org/show_bug.cgi?id=198342
+        <rdar://problem/51228563>
+
+        Reviewed by Wenson Hsieh.
+
+        In some configurations, VideoFullscreenInterfaceAVKit.mm declares but
+        does not use makeWindowFromView. Fix by conditionalizing the the
+        declaration on the same symbol as point where it's used.
+
+        No new tests -- no new functionality.
+
+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+
 2019-05-28  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm

@@ -1178 +1178 @@
 }
 
+#if !PLATFORM(WATCHOS)
 #if USE(APPLE_INTERNAL_SDK)
 #import <WebKitAdditions/VideoFullscreenInterfaceAVKitAdditions.mm>
@@ -1185 +1186 @@
     return adoptNS([PAL::allocUIWindowInstance() initWithFrame:[[PAL::getUIScreenClass() mainScreen] bounds]]);
 }
+#endif
 #endif