Changeset 245879 in webkit

Timestamp:

May 29, 2019, 4:53:57 PM (7 years ago)

Author:

Justin Michaud

Message:

Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
​https://bugs.webkit.org/show_bug.cgi?id=198322

Rubber-stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds.
This matches what we do for other jsc tests.

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-29  Justin Michaud  <justin_michaud@apple.com>
+
+        Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
+        https://bugs.webkit.org/show_bug.cgi?id=198322
+
+        Rubber-stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds. 
+        This matches what we do for other jsc tests. 
+
+        * Scripts/run-jsc-stress-tests:
+
 2019-05-29  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -1082 +1082 @@
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
@@ -1100 +1100 @@
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
@@ -1120 +1120 @@
         run("wasm-no-tls-context", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-no-air", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end
@@ -1146 +1146 @@
       runWithOutputHandler("wasm-no-tls-context", noisyOutputHandler, "../spec-harness.js", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
       runWithOutputHandler("wasm-no-air", noisyOutputHandler, "../spec-harness.js", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
+      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously?
     end
 end