Changeset 245900 in webkit

Timestamp:

May 30, 2019, 12:41:53 PM (7 years ago)

Author:

Alan Bujtas

Message:

[iOS] Do not linkify telephone numbers inside <a> elements.
​https://bugs.webkit.org/show_bug.cgi?id=198378

Reviewed by Chris Dumez.

Source/WebCore:

Phone number linkifying mutates the DOM in a potentially unexpected way triggering different kinds of failures with JS, CSS selectors etc.
This patch tightens the linkifying rule so that content inside an <a> element won't get linkified even when the <a> has no valid href attribute.

Test: fast/dom/linkify-phone-numbers.html

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::disallowTelephoneNumberParsing):

LayoutTests:

• fast/dom/linkify-phone-numbers-expected.html: Added.
• fast/dom/linkify-phone-numbers.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/fast/dom/linkify-phone-numbers-expected.html (added)
• LayoutTests/fast/dom/linkify-phone-numbers.html (added)
• LayoutTests/platform/ios/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/parser/HTMLTreeBuilder.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-30  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] Do not linkify telephone numbers inside <a> elements.
+        https://bugs.webkit.org/show_bug.cgi?id=198378
+
+        Reviewed by Chris Dumez.
+
+        * fast/dom/linkify-phone-numbers-expected.html: Added.
+        * fast/dom/linkify-phone-numbers.html: Added.
+
 2019-05-30  Jer Noble  <jer.noble@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -3102 +3102 @@
 
 webkit.org/b/198103 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/currentTime.html [ Pass Failure ]
+
+# iOS only
+fast/dom/linkify-phone-numbers.html [ ImageOnlyFailure ]

trunk/LayoutTests/platform/ios/TestExpectations

@@ -2225 +2225 @@
 webkit.org/b/148806 imported/w3c/web-platform-tests/css/css-multicol/multicol-span-all-margin-nested-firstchild-001.xht [ ImageOnlyFailure ]
 
+# Enable "phone number linkifying" test for iOS
+fast/dom/linkify-phone-numbers.html [ Pass ]
+
 # Enable "aria-current" test for iOS
 webkit.org/b/149297 accessibility/aria-current.html [ Pass ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-30  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] Do not linkify telephone numbers inside <a> elements.
+        https://bugs.webkit.org/show_bug.cgi?id=198378
+
+        Reviewed by Chris Dumez.
+
+        Phone number linkifying mutates the DOM in a potentially unexpected way triggering different kinds of failures with JS, CSS selectors etc.
+        This patch tightens the linkifying rule so that content inside an <a> element won't get linkified even when the <a> has no valid href attribute.
+
+        Test: fast/dom/linkify-phone-numbers.html
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::disallowTelephoneNumberParsing):
+
 2019-05-30  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -2259 +2259 @@
 {
     return node.isLink()
+        || node.hasTagName(aTag)
         || node.hasTagName(scriptTag)
         || is<HTMLFormControlElement>(node)