Changeset 245907 in webkit

Timestamp:

May 30, 2019, 4:06:34 PM (7 years ago)

Author:

Wenson Hsieh

Message:

DragAndDropTests.DataTransferExposePlainTextWithFileURLAsFile API test is failing
​https://bugs.webkit.org/show_bug.cgi?id=198389
<rdar://problem/51266096>

Reviewed by Tim Horton.

This test started failing, since the fallback name for a dropped text file changed from "text.txt" to
"Document.txt" on newer iOS SDK versions. We simply fix this test by checking that the name of the file ends
with ".txt", and that the MIME type of the file is "text/plain".

• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-30  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        DragAndDropTests.DataTransferExposePlainTextWithFileURLAsFile API test is failing
+        https://bugs.webkit.org/show_bug.cgi?id=198389
+        <rdar://problem/51266096>
+
+        Reviewed by Tim Horton.
+
+        This test started failing, since the fallback name for a dropped text file changed from "text.txt" to
+        "Document.txt" on newer iOS SDK versions. We simply fix this test by checking that the name of the file ends
+        with ".txt", and that the MIME type of the file is "text/plain".
+
+        * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
+        (TestWebKitAPI::TEST):
+
 2019-05-30  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm

@@ -1922 +1922 @@
     EXPECT_WK_STREQ("", [webView stringByEvaluatingJavaScript:@"htmlData.textContent"]);
     EXPECT_WK_STREQ("(FILE, text/plain)", [webView stringByEvaluatingJavaScript:@"items.textContent"]);
-    EXPECT_WK_STREQ("('text.txt', text/plain)", [webView stringByEvaluatingJavaScript:@"files.textContent"]);
+
+    NSString *filesOutput = [webView stringByEvaluatingJavaScript:@"files.textContent"];
+    EXPECT_TRUE([filesOutput containsString:@"text/plain)"]);
+    EXPECT_TRUE([filesOutput containsString:@".txt', "]);
 }