Changeset 245929 in webkit

Timestamp:

May 30, 2019, 5:30:25 PM (7 years ago)

Author:

Alan Coon

Message:

Apply patch. rdar://problem/50801017

Location:

branches/safari-607-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderView.cpp (modified) (1 diff)

branches/safari-607-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-30  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Apply patch. rdar://problem/50801017
+
+    2019-05-30  Brent Fulgham  <bfulgham@apple.com>
+
+            Improve safety of HitTest logic
+            https://bugs.webkit.org/show_bug.cgi?id=198030
+            <rdar://problem/50801017>
+
+            Reviewed by Alan Bujtas.
+
+            Don't use the RenderView during hit testing until after all
+            layout is complete.
+
+            * rendering/RenderView.cpp:
+            (WebCore::RenderView::hitTest):
+
 2019-05-30  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-607-branch/Source/WebCore/rendering/RenderView.cpp

@@ -145 +145 @@
 bool RenderView::hitTest(const HitTestRequest& request, const HitTestLocation& location, HitTestResult& result)
 {
+    auto weakRenderView = makeWeakPtr(this);
+
     document().updateLayout();
+
+    if (!weakRenderView)
+        return false;
     
 #if !ASSERT_DISABLED