Changeset 245954 in webkit

Timestamp:

May 31, 2019, 1:12:45 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r244182): [GTK] Web view no longer updated after re-entering AC mode
​https://bugs.webkit.org/show_bug.cgi?id=198367

Reviewed by Sergio Villar Senin.

This happens because we leave accelerated compositing mode when a rendering update is scheduled in
RenderingUpdateScheduler. The ThreadedDisplayRefreshMonitor is destroyed without completing the
frame, so that the RenderingUpdateScheduler is left scheduled forever, ignoring any new schedule request. We
need to ensure we complete the frame request before destroying the display refresh monitor to leave the
RenderingUpdateScheduler in a consistent state.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::invalidate):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r244182): [GTK] Web view no longer updated after re-entering AC mode
+        https://bugs.webkit.org/show_bug.cgi?id=198367
+
+        Reviewed by Sergio Villar Senin.
+
+        This happens because we leave accelerated compositing mode when a rendering update is scheduled in
+        RenderingUpdateScheduler. The ThreadedDisplayRefreshMonitor is destroyed without completing the
+        frame, so that the RenderingUpdateScheduler is left scheduled forever, ignoring any new schedule request. We
+        need to ensure we complete the frame request before destroying the display refresh monitor to leave the
+        RenderingUpdateScheduler in a consistent state.
+
+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
+        (WebKit::ThreadedDisplayRefreshMonitor::invalidate):
+
 2019-05-30  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp

@@ -86 +86 @@
 {
     m_displayRefreshTimer.stop();
+    bool wasScheduled = false;
+    {
+        LockHolder locker(mutex());
+        wasScheduled = isScheduled();
+    }
+    if (wasScheduled)
+        DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this);
     m_client = nullptr;
 }