⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 246028 in webkit


Ignore:
Timestamp:
Jun 2, 2019, 10:28:58 PM (7 years ago)
Author:
Fujii Hironori
Message:

[WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
https://bugs.webkit.org/show_bug.cgi?id=198474

Reviewed by Darin Adler.

WinCairo WK2 MiniBrowser can't play back videos because
Page::canStartMedia() always returns false. WKViewSetIsInWindow
should be called.

The original MiniBrowser did it in Bug 55364.

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::WebKitBrowserWindow): Call WKViewSetIsInWindow.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r246012 r246028  
     12019-06-02  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
     4        https://bugs.webkit.org/show_bug.cgi?id=198474
     5
     6        Reviewed by Darin Adler.
     7
     8        WinCairo WK2 MiniBrowser can't play back videos because
     9        Page::canStartMedia() always returns false. WKViewSetIsInWindow
     10        should be called.
     11
     12        The original MiniBrowser did it in Bug 55364.
     13
     14        * MiniBrowser/win/WebKitBrowserWindow.cpp:
     15        (WebKitBrowserWindow::WebKitBrowserWindow): Call WKViewSetIsInWindow.
     16
    1172019-05-31  Sihui Liu  <sihui_liu@apple.com>
    218
  • trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp

    r244390 r246028  
    130130    RECT rect = { };
    131131    m_view = adoptWK(WKViewCreate(rect, conf, mainWnd));
     132    WKViewSetIsInWindow(m_view.get(), true);
     133
    132134    auto page = WKViewGetPage(m_view.get());
    133135
Note: See TracChangeset for help on using the changeset viewer.