Changeset 246032 in webkit

Timestamp:

Jun 3, 2019, 2:43:41 AM (7 years ago)

Author:

Fujii Hironori

Message:

REGRESSION(r240862) [WinCairo][WK2] position:fixed elements don't show
​https://bugs.webkit.org/show_bug.cgi?id=198478

Reviewed by Carlos Garcia Campos.

All position:fixed elements didn't show in WinCairo WebKit2 since
r240862 which turns acceleratedCompositingEnabled on for WebKit2.
WinCairo WebKit2 doesn't have accelerated compositing support yet.
Let's do the same with GTK port.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Conditioned out the code
enabling acceleratedCompositingEnabled for PLATFORM(WIN).

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        REGRESSION(r240862) [WinCairo][WK2] position:fixed elements don't show
+        https://bugs.webkit.org/show_bug.cgi?id=198478
+
+        Reviewed by Carlos Garcia Campos.
+
+        All position:fixed elements didn't show in WinCairo WebKit2 since
+        r240862 which turns acceleratedCompositingEnabled on for WebKit2.
+        WinCairo WebKit2 doesn't have accelerated compositing support yet.
+        Let's do the same with GTK port.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences): Conditioned out the code
+        enabling acceleratedCompositingEnabled for PLATFORM(WIN).
+
 2019-06-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

@@ -3520 +3520 @@
     Settings& settings = m_page->settings();
 
-#if !PLATFORM(GTK)
+#if !PLATFORM(GTK) && !PLATFORM(WIN)
     if (!settings.acceleratedCompositingEnabled()) {
         RELEASE_LOG_IF_ALLOWED("%p - WebPage - acceleratedCompositingEnabled setting was false. WebKit cannot function in this mode; changing setting to true", this);