Changeset 246080 in webkit

Timestamp:

Jun 4, 2019, 2:27:07 PM (7 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Do not display unnecessary steps in the Buildbot build page UI
​https://bugs.webkit.org/show_bug.cgi?id=198218
<rdar://problem/51104544>

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -140 +140 @@
         d.addCallback(lambda res: shell.ShellCommand.start(self))
 
+    def hideStepIf(self, results, step):
+        return results == SUCCESS and self.getProperty('validated', '') == False
+
     def getResultSummary(self):
         if self.results != SUCCESS:
@@ -369 +372 @@
         if obsolete == -1 or review_denied == -1 or bug_closed == -1:
             self.finished(WARNINGS)
+            self.setProperty('validated', False)
             return None
 
@@ -809 +813 @@
 
         return super(TransferToS3, self).finished(results)
+
+    def hideStepIf(self, results, step):
+        return results == SUCCESS and self.getProperty('validated', '') == False
 
     def getResultSummary(self):

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-04  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Do not display unnecessary steps in the Buildbot build page UI
+        https://bugs.webkit.org/show_bug.cgi?id=198218
+        <rdar://problem/51104544>
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+
 2019-06-04  Sihui Liu  <sihui_liu@apple.com>