Changeset 246085 in webkit

Timestamp:

Jun 4, 2019, 3:56:37 PM (7 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r244557): Leak of WKNSString in WTR::runOpenPanel() while running WebKit layout tests
<​https://webkit.org/b/198538>
<rdar://problem/51407719>

Reviewed by Darin Adler.

• WebKitTestRunner/TestController.cpp:

(WTR::runOpenPanel): Use adoptWK() to fix the leak.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-04  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r244557): Leak of WKNSString in WTR::runOpenPanel() while running WebKit layout tests
+        <https://webkit.org/b/198538>
+        <rdar://problem/51407719>
+
+        Reviewed by Darin Adler.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::runOpenPanel): Use adoptWK() to fix the leak.
+
 2019-06-04  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -205 +205 @@
     
 #if PLATFORM(IOS_FAMILY)
-    WKStringRef displayString = WKURLCopyLastPathComponent(static_cast<WKURLRef>(firstItem));
+    auto displayString = adoptWK(WKURLCopyLastPathComponent(static_cast<WKURLRef>(firstItem)));
     WKDataRef mediaIcon = TestController::singleton().openPanelFileURLsMediaIcon();
     
     if (mediaIcon) {
         if (WKOpenPanelParametersGetAllowsMultipleFiles(parameters)) {
-            WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, fileURLs, displayString, mediaIcon);
+            WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, fileURLs, displayString.get(), mediaIcon);
             return;
         }
         
-        WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, adoptWK(WKArrayCreate(&firstItem, 1)).get(), displayString, mediaIcon);
+        WKOpenPanelResultListenerChooseMediaFiles(resultListenerRef, adoptWK(WKArrayCreate(&firstItem, 1)).get(), displayString.get(), mediaIcon);
         return;
     }