Changeset 246089 in webkit

Timestamp:

Jun 4, 2019, 5:11:10 PM (7 years ago)

Author:

youenn@apple.com

Message:

Layout test landed flaky in 245873 [ Release ] http/wpt/service-workers/service-worker-networkprocess-crash.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=198435
<rdar://problem/51314295>

Reviewed by Alex Christensen.

Make the test more robust by retrying the null test more than once.

• http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt:
• http/wpt/service-workers/service-worker-networkprocess-crash.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt (modified) (1 diff)
• http/wpt/service-workers/service-worker-networkprocess-crash.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-04  Youenn Fablet  <youenn@apple.com>
+
+        Layout test landed flaky in 245873 [ Release ] http/wpt/service-workers/service-worker-networkprocess-crash.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=198435
+        <rdar://problem/51314295>
+
+        Reviewed by Alex Christensen.
+
+        Make the test more robust by retrying the null test more than once.
+
+        * http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt:
+        * http/wpt/service-workers/service-worker-networkprocess-crash.html:
+
 2019-06-04  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt

@@ +1 @@
+
 
 PASS Setup worker 

trunk/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html

@@ -49 +49 @@
         testRunner.terminateNetworkProcess();
 
-    const frame = await withFrame(scope + "/empty.html");
-    assert_not_equals(frame.contentWindow.navigator.serviceWorker.controller, null);
-    frame.remove();
+    let count = 0;
+    while (count++ < 20) {
+        const frame = await withFrame(scope + "/empty.html");
+        if (frame.contentWindow.navigator.serviceWorker.controller)
+            break;
+        frame.remove();
+        await new Promise(resolve => setTimeout(resolve, 50));
+    }
+    assert_true(count < 20);
 }, "Frame being controlled after network process crash");
 </script>