Changeset 246100 in webkit

Timestamp:

Jun 4, 2019, 11:34:56 PM (7 years ago)

Author:

bshafiei@apple.com

Message:

Cherry-pick r246099. rdar://problem/48006291

iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
​https://bugs.webkit.org/show_bug.cgi?id=198556

Reviewed by Wenson Hsieh.

Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
a software keyboard enabled because tapping on date brings up software keyboard and erratically
shifts up/down the new event dialog/pane.

Add a site specific quirk to pretend these input elements have inputmode=none for now.

No new tests since this is a site specific quirk.

• page/Quirks.cpp: (WebCore::Quirks::needsInputModeNoneImplicitly const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608.1.27-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

branches/safari-608.1.27-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-04  Babak Shafiei  <bshafiei@apple.com>
+
+        Cherry-pick r246099. rdar://problem/48006291
+
+    iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
+    https://bugs.webkit.org/show_bug.cgi?id=198556
+    
+    Reviewed by Wenson Hsieh.
+    
+    Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
+    a software keyboard enabled because tapping on date brings up software keyboard and erratically
+    shifts up/down the new event dialog/pane.
+    
+    Add a site specific quirk to pretend these input elements have inputmode=none for now.
+    
+    No new tests since this is a site specific quirk.
+    
+    * page/Quirks.cpp:
+    (WebCore::Quirks::needsInputModeNoneImplicitly const):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-06-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+            iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
+            https://bugs.webkit.org/show_bug.cgi?id=198556
+
+            Reviewed by Wenson Hsieh.
+
+            Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
+            a software keyboard enabled because tapping on date brings up software keyboard and erratically
+            shifts up/down the new event dialog/pane.
+
+            Add a site specific quirk to pretend these input elements have inputmode=none for now.
+
+            No new tests since this is a site specific quirk.
+
+            * page/Quirks.cpp:
+            (WebCore::Quirks::needsInputModeNoneImplicitly const):
+
 2019-06-03  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-608.1.27-branch/Source/WebCore/page/Quirks.cpp

@@ -339 +339 @@
         return false;
 
+    if (element.hasTagName(HTMLNames::inputTag)) {
+        if (!equalLettersIgnoringASCIICase(m_document->url().host(), "calendar.google.com"))
+            return false;
+        static NeverDestroyed<QualifiedName> dataInitialValueAttr(nullAtom(), "data-initial-value", nullAtom());
+        static NeverDestroyed<QualifiedName> dataPreviousValueAttr(nullAtom(), "data-previous-value", nullAtom());
+
+        return equalLettersIgnoringASCIICase(element.attributeWithoutSynchronization(HTMLNames::autocompleteAttr), "off")
+            && element.hasAttributeWithoutSynchronization(dataInitialValueAttr)
+            && element.hasAttributeWithoutSynchronization(dataPreviousValueAttr);
+    }
+
     if (!element.hasTagName(HTMLNames::textareaTag))
         return false;