Changeset 246182 in webkit

Timestamp:

Jun 6, 2019, 5:23:12 PM (7 years ago)

Author:

Brent Fulgham

Message:

Avoid generating new XSLT-based document when already changing the document.
​https://bugs.webkit.org/show_bug.cgi?id=198525
<rdar://problem/51393787>

Reviewed by Ryosuke Niwa.

We should not allow a pending XSLT transform to change the current document when
that current document is int he process of being replaced.

• dom/Document.cpp:

(WebCore::Document::applyPendingXSLTransformsTimerFired):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-06  Brent Fulgham  <bfulgham@apple.com>
+
+        Avoid generating new XSLT-based document when already changing the document.
+        https://bugs.webkit.org/show_bug.cgi?id=198525
+        <rdar://problem/51393787>
+
+        Reviewed by Ryosuke Niwa.
+
+        We should not allow a pending XSLT transform to change the current document when
+        that current document is int he process of being replaced.
+
+        * dom/Document.cpp:
+        (WebCore::Document::applyPendingXSLTransformsTimerFired):
+
 2019-06-06  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -5483 +5483 @@
             return;
 
+        // If the Document has already been detached from the frame, or the frame is currently in the process of
+        // changing to a new document, don't attempt to create a new Document from the XSLT.
+        if (!frame() || frame()->documentIsBeingReplaced())
+            return;
+
         auto processor = XSLTProcessor::create();
         processor->setXSLStyleSheet(downcast<XSLStyleSheet>(processingInstruction->sheet()));