Changeset 246208 in webkit

Timestamp:

Jun 7, 2019, 10:57:12 AM (7 years ago)

Author:

bshafiei@apple.com

Message:

Cherry-pick r246205. rdar://problem/51345064

Limit simulated mouse events on Google Maps to entering Street View
​https://bugs.webkit.org/show_bug.cgi?id=198657
<rdar://problem/51345064>

Reviewed by Brent Fulgham.

• page/Quirks.cpp: (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const): (WebCore::Quirks::shouldDispatchSimulatedMouseEventsOnTarget const):
• page/Quirks.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@246205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-608.1.27-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (2 diffs)
• page/Quirks.h (modified) (1 diff)

branches/safari-608.1.27-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-07  Babak Shafiei  <bshafiei@apple.com>
+
+        Cherry-pick r246205. rdar://problem/51345064
+
+    Limit simulated mouse events on Google Maps to entering Street View
+    https://bugs.webkit.org/show_bug.cgi?id=198657
+    <rdar://problem/51345064>
+    
+    Reviewed by Brent Fulgham.
+    
+    * page/Quirks.cpp:
+    (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+    (WebCore::Quirks::shouldDispatchSimulatedMouseEventsOnTarget const):
+    * page/Quirks.h:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-06-07  Antoine Quint  <graouts@apple.com>
+
+            Limit simulated mouse events on Google Maps to entering Street View
+            https://bugs.webkit.org/show_bug.cgi?id=198657
+            <rdar://problem/51345064>
+
+            Reviewed by Brent Fulgham.
+
+            * page/Quirks.cpp:
+            (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+            (WebCore::Quirks::shouldDispatchSimulatedMouseEventsOnTarget const):
+            * page/Quirks.h:
+
 2019-06-06  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-608.1.27-branch/Source/WebCore/page/Quirks.cpp

@@ -279 +279 @@
 }
 
+#if PLATFORM(IOS_FAMILY)
 bool Quirks::shouldDispatchSimulatedMouseEvents() const
 {
-#if PLATFORM(IOS_FAMILY)
     if (!needsQuirks())
         return false;
@@ -314 +314 @@
     if (equalLettersIgnoringASCIICase(host, "naver.com") || host.endsWithIgnoringASCIICase(".naver.com"))
         return true;
-#endif
-    return false;
-}
+    return false;
+}
+
+bool Quirks::shouldDispatchSimulatedMouseEventsOnTarget(EventTarget* target) const
+{
+    if (!needsQuirks() || !shouldDispatchSimulatedMouseEvents())
+        return false;
+
+    // On Google Maps, we want to limit simulated mouse events to dragging the little man that allows entering into Street View.
+    auto& url = m_document->topDocument().url();
+    auto host = url.host();
+    if (equalLettersIgnoringASCIICase(host, "www.google.com") && url.path().startsWithIgnoringASCIICase("/maps/"))
+        return is<Element>(target) && downcast<Element>(target)->getAttribute("class") == "widget-expand-button-pegman-icon";
+    return true;
+}
+#endif
 
 bool Quirks::shouldDisablePointerEventsQuirk() const

branches/safari-608.1.27-branch/Source/WebCore/page/Quirks.h

@@ -50 +50 @@
     bool hasBrokenEncryptedMediaAPISupportQuirk() const;
     bool hasWebSQLSupportQuirk() const;
+#if PLATFORM(IOS_FAMILY)
     bool shouldDispatchSimulatedMouseEvents() const;
+    bool shouldDispatchSimulatedMouseEventsOnTarget(EventTarget*) const;
+#endif
     bool shouldDisablePointerEventsQuirk() const;
     bool needsInputModeNoneImplicitly(const HTMLElement&) const;